On Mon, Mar 01, 2010 at 09:24:55AM -0000, Luca Invernizzi wrote:
> I've not been involved in the refactoring so I'll just drop my thoughts:
>
> That certainly fixes it, but I have two questions:
> - I remember Lionel saying "always pass ids as arguments, never objects except when needed". Shouldn't the tid be passed instead?
Yeah, but making the fix this way was a bit too advanced for me.
> - the add_parent declaration in task.py has a comment "Take a tid object as parameter", but it really wants a task object.
I think this is the real bug here. My "fix" just works around this
problem, but maybe helps confirm this as the issue.
On Mon, Mar 01, 2010 at 09:24:55AM -0000, Luca Invernizzi wrote:
> I've not been involved in the refactoring so I'll just drop my thoughts:
>
> That certainly fixes it, but I have two questions:
> - I remember Lionel saying "always pass ids as arguments, never objects except when needed". Shouldn't the tid be passed instead?
Yeah, but making the fix this way was a bit too advanced for me.
> - the add_parent declaration in task.py has a comment "Take a tid object as parameter", but it really wants a task object.
I think this is the real bug here. My "fix" just works around this
problem, but maybe helps confirm this as the issue.
Bryce