"insert a subtask" button causes freeze, then force quit

[kokoshmusun]

I use Ubuntu Karmic and GTG 0.2.

I added a task, and within it, a subtask. In the task window, the cursor is right by the subtask. While there, I click on the "insert a subtask" button. This freezes GTG, then it says its crashed, and I choose force quit.

Maybe this isn't something I'm supposed to do (as I'm still in the process of figuring out how to use GTG)???

[Luca Invernizzi (invernizzi)]

Curious. I can't reproduce, while Bertrand can.

[Bertrand Rousseau (bertrand-rousseau)]

I did the following:

1) create a task
2) in the editor, type "- something<enter>"
3) push on the "insert subtask" toolbar button of the editor

During step 3, the carret is indeed placed after a subtask arrow "->"

On Sun, Jan 31, 2010 at 10:14 PM, Luca Invernizzi <email address hidden>wrote:

> Curious. I can't reproduce, while Bertrand can.
>
> --
> "insert a subtask" button causes freeze, then force quit
> https://bugs.launchpad.net/bugs/515174
> You received this bug notification because you are subscribed to Getting
> Things GNOME!.
>

--
Bertrand Rousseau

[Luca Invernizzi (invernizzi)]

ok, thanks

[Kevin Mehall (kevin-mehall)]

For me, it happens sometimes, but not often. I couldn't reproduce it, but then it happened about 5 times in a row, and now I can't reproduce it again.

[Kevin Mehall (kevin-mehall)]

I've found that it only occurs if there is no text (not even a newline) after the last subtask

[Jeff Oliver (jeffrey-oliver)]

It looks like the code gets stuck spinning 100% CPU if it can't find a place to put the new subtask within the text editor window. Looking at the code in this area, there is a blind line += 1, without regard to the number of lines in the buffer.

[Jeff Oliver (jeffrey-oliver)]

I quickly hacked in a little check to see if the line that was found to insert the new task was the last one, if so, I insert a new CR at the end of it and let the rest of the code do its job. A patch is attached.

[Luca Invernizzi (invernizzi)]

Hey, Jeff, thanks for the patch! It's always nice to fix a critical bug.
Committed to trunk