Seems like gtg confuses tomboy with gnote

Bug #495141 reported by mrk on 2009-12-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Getting Things GNOME!
Medium
Luca Invernizzi

Bug Description

Good day!

I have not tomboy installed, but have gnote instead. When i activate tomboy plugin in Plugins window, i cannot edit any existing/new task anymore. I've got this traceback (when try to edit task):

Traceback (most recent call last):
  File "/usr/local/lib/python2.6/site-packages/GTG/taskbrowser/browser.py", line 1336, in on_edit_active_task
    self.open_task(tid)
  File "/usr/local/lib/python2.6/site-packages/GTG/taskbrowser/browser.py", line 754, in open_task
    clipboard = self.clipboard)
  File "/usr/local/lib/python2.6/site-packages/GTG/taskeditor/editor.py", line 192, in __init__
    self.pengine.onTaskLoad(self.plugins, self.te_plugin_api)
  File "/usr/local/lib/python2.6/site-packages/GTG/core/plugins/engine.py", line 199, in onTaskLoad
    plugin['instance'].onTaskOpened(plugin_api)
  File "/usr/local/lib/python2.6/site-packages/GTG/plugins/tomboy/tomboy.py", line 167, in onTaskOpened
    self.addButtonToToolbar(plugin_api)
  File "/usr/local/lib/python2.6/site-packages/GTG/plugins/tomboy/tomboy.py", line 117, in addButtonToToolbar
    tb_Taskbutton_image_path = self.tomboy_icon_path
AttributeError: pluginTomboy instance has no attribute 'tomboy_icon_path'

When i disable tomboy plugin, i can edit any tasks as before.
I think that gtg confuses tomboy with gnote because they "looks" identically (dbus resources) but have some differences in API. I may be totally wrong, but the fact is - i can activate tomboy plugin without tomboy installed and make some mess with it ). May be gtg should know how to work with gnote or it anyhow should distinct tomboy from gnote. I'm using 0.1.99 and can provide any more details if needed.

Thanks for the great release!

Related branches

Luca Invernizzi (invernizzi) wrote :

Thanks for the bug report.
GTG can't work with gnote as it does with tomboy, since gnote does not provide a dbus interface.
Your bug has been fixed in lp:~invernizzi/gtg/tomboy-fix . Gtg developers, please consider a merge.

Changed in gtg:
status: New → Won't Fix
status: Won't Fix → Fix Committed

It is not commited as it's in your branch, not in trunk.

Changed in gtg:
status: Fix Committed → In Progress
Changed in gtg:
status: In Progress → Fix Committed
mrk (cvs-src) wrote :

Mmm.. are you sure about dbus? From gnote changelog:

0.6.0 "We believe in D-Bus" - 2009/07/29

New Features:

  * Implement org.gnome.Gnote.RemoteControl to mimic Tomboy DBus API.
    (Closes #581030)

Luca Invernizzi (invernizzi) wrote :

Interesting. I opened bug #495729 for that. Please check it out

Changed in gtg:
assignee: nobody → Luca Invernizzi (invernizzi)
importance: Undecided → Medium
milestone: none → 0.2
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers