Ctrl-return does not traverse link

Bug #369272 reported by David Allouche on 2009-04-29
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Getting Things GNOME!
Medium
Bertrand Rousseau

Bug Description

Observed behaviour: ctrl-return while the caret is within a link insert a newline.

Expected behaviour: ctrl-return while the caret is within a link should traverse the link.

Justification: There does not appear to be a way to traverse a link using the keyboard and no mouse at the moment. In Tomboy, you can traverse links with the keyboard by pressing ctrl-return.

Lionel Dricot (ploum) wrote :

By "traverse", do you mean "opening the link in a browser" ?

If yes, I agree that it would be a nice feature to have.

Changed in gtg:
importance: Undecided → Medium
milestone: none → 0.2
status: New → Confirmed
bendowling (ben-m-dowling) wrote :

Hi Guys,

I've written a fix for this bug. How do I go about submitting a patch?

Thanks, Ben

Lionel Dricot (ploum) wrote :

hi bendowling,

please see http://live.gnome.org/gtg/contributing (and ask if you have any question)

bendowling (ben-m-dowling) wrote :

I guess this is as good a place as any! :)

Feedback appreciated.

Thanks, Ben

bendowling (ben-m-dowling) wrote :

Ahh sorry Lionel, didn't see your comment. I'll follow the steps in that guide. Thanks!

bendowling (ben-m-dowling) wrote :

I'm keen to commit my fix, but I'm having problems with LP login at the minute: https://answers.launchpad.net/launchpad/+question/73243

Once I've got to the bottom of that I'll commit the change.

Thanks, Ben

bendowling (ben-m-dowling) wrote :

I've sorted the lp login problem now. I followed the steps in the guide and I've pushed my changes to lp:~gtg-user/gtg/bendowling_branch, and now I'm requesting a merge. Let me know if I need to do anything else.

Thanks, Ben

Changed in gtg:
status: Confirmed → Fix Committed

Merged in revision 249 of trunk. Thanks a lot!

Lionel Dricot (ploum) on 2009-06-10
Changed in gtg:
assignee: nobody → Bertrand Rousseau (bertrand-rousseau)
Lionel Dricot (ploum) on 2009-06-18
Changed in gtg:
milestone: 0.2 → 0.1.2
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments