Undo support in the task editor

Bug #343328 reported by Xavier Lepaul on 2009-03-15
This bug affects 22 people
Affects Status Importance Assigned to Milestone
Getting Things GNOME!

Bug Description

I don't think this needs more information.
Ctrl-A Delete should not be such a deadly weapon.

Alexey Kostyuk (unitoff) wrote :

Undo\Redo\Cut hotkeys doesn't work in task editor

Changed in gtg:
importance: Undecided → Medium
milestone: none → 0.2
status: New → Confirmed
perriman (chuchiperriman) wrote :

You can use gtksourceview widget. It has undo/redo features, highlighting etc.

Lionel Dricot (ploum) wrote :

gtksourceview seems to have lot of problems in the long run. Many software (such as pyroom) are working hard to go back to standard textview. So I think it's better to avoid sourceview as long as it's not an official part of gtk.

perriman (chuchiperriman) wrote :

Do the gtksourceview people know about that problem? I think it is better fix the gtksourceview problem... You can disable highlighting if you want and the gtg text of a task is very small.

Changed in gtg:
milestone: 0.2 → 0.3

Undo is critical functionality for me - GTG is painful without it... Add it please lovely developer people!

Luca Invernizzi (invernizzi) wrote :

Hello guys,
I quickly added an undo buffer to gtg task by using some existing code (http://bitbucket.org/tiax/gtk-textbuffer-with-undo/).
There is no graphical change now, but your CTRL+z will undo and CTRL+r will redo.
to test:
bzr branch lp:~gtg-user/gtg/undo_in_tasks
cd undo*
./scripts/debug -d

What it basically does is expand gtk.TextBuffer to add undo/redo of generic objects. I've already seen that all our "intelligent" objects (subtasks, tomboy links...) do not function out of the box, but the code is very clear, thus easy to modify.
Please tell me what you think.
 GTG developers, I'm expecially interesting in your opinion: once you give me the go, I will write this properly :-D.

ps: do not signal bug on this. It's just a proof of concept. Opinions on the general approach., on the other hand, are always welcome.

Luca Invernizzi (invernizzi) wrote :

last thing: I mailed the author about the license under which the code is released. It's LGpl, so we should have no problems of that kind.

Lionel Dricot (ploum) wrote :

Luca > it looks like the "enter" key is not working in an editor in your branch. Strange, isn't it?

Luca Invernizzi (invernizzi) wrote :

I'll have to wait/address first the process of adding and removing a subtask, since it sometimes leaves some leftovers (arrows and such) that screw up the undo function.

Changed in gtg:
status: Confirmed → In Progress
assignee: nobody → Luca Invernizzi (invernizzi)
Luca Invernizzi (invernizzi) wrote :

I'm quite stuck with this one, so if anyone wants to join the effort (or take a completely different approach), I'll be happy :-D

Luca Invernizzi (invernizzi) wrote :

I'm dropping this one since I'm not really working on it, and I hate to have open bugs filed against me :-D
If you want, you can fork and verbally abuse my work at lp:~gtg-user/gtg/undo_in_tasks

Changed in gtg:
assignee: Luca Invernizzi (invernizzi) → nobody

what about the text browser of tomboy?
Isn't it possible to reuse that one? It supports a lot of things like strike through, text sizes and also undo function.

Luca Invernizzi (invernizzi) wrote :

It's not that easy. Tomboy is written in another language, and code reuse is not really a possibility.

Lionel Dricot (ploum) on 2010-06-15
Changed in gtg:
milestone: 0.3 → 0.4

IS this still "In progress", doesn't seems so (Last update of branch, no very recent comments...).

 I think we should put this as confirmed, so anyone that want to handle the bug won't think "If it's in Progress it's that anyone is currently working on it."

 Not setting to Confirmed, as I'm not no one is working on this. If a developper could mark as confirmed or say it's In progress it would be good.

Changed in gtg:
status: In Progress → Triaged
tklingenberg (tklingenberg) wrote :

Would be nice to see undo support in there.

Izidor Matušov (izidor) on 2011-08-12
tags: added: editor taskeditor

Ouch, this is a bad one. I just lost a note by accident, i.e. pressing super + tab on a selection instead of alt+tab. So my note has been replaced with a tab :-( Unfortunately, the change has not yet made it into the backup so I can't recover from there :-(

So I consider this a real bummer for using gtg.

Changed in gtg:
importance: Medium → High
status: Triaged → Confirmed
status: Confirmed → Triaged
Changed in gtg:
importance: High → Wishlist
Marcel Partap (empee584) wrote :

Please test the attached patch.. it's a quick hack, but I found no problems so far. Keep your data backupped in any case.

Why moving this issue to "Wishlist"? In my opinion this is quite a critical feature for any application that implements text edition. This bug has been opened for more than 5 years now, a patch has been submitted by Marcel 9 months ago and it doesn't seem any GTG developer reviewed it yet.

I saw in comments that there were potential problems with gtksourceview, is this still valid? If Marcel's patch doesn't fit because of gtksourceview usage, or for any other reason, I'd be happy to try to also try to contribute a patch, but could any maintainer keep us updated about the status of this issue please?

PS: don't get me wrong, I'm not ranting, I'm just really surprised to see such a feature is missing in GTG.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers