The expanding state should be remembered accross refresh

[Lionel Dricot]

Because expand_all for each refresh can be annoying

[Lionel Dricot (ploum-deactivatedaccount)]

Fixed in rev. 125. Bertrand, could you save the self.expanded_tid variable (a list of string) in the conf file ?

[Bertrand Rousseau (bertrand-rousseau)]

Reopening since expanded state is not preserved when you select a different tag:

1) Select a tag
2) Expand a task
3) Select another tag
4) Return to the first tag

The expanded task is collapsed

I guess we have to store the list of expanded tasks, and restore it at each refresh. We could store this information in the configuration file, as you ask.

I'm taking charge of this bug since I will implement the storage the expanded state in the config file as well (see bug #322120).

[Bertrand Rousseau (bertrand-rousseau)]

More precisely:

1) Select a tag
2) Expand a task
3) Select another tag (which the expanded task doesn't have)
4) Return to the first tag

[Bertrand Rousseau (bertrand-rousseau)]

Re-fixed

[Lionel Dricot (ploum-deactivatedaccount)]

> I guess we have to store the list of expanded tasks, and restore it at
> each refresh. We could store this information in the configuration file,
> as you ask.

That's what we are doing now. This list is created at every refresh. If
you switch to another tag, it will list the currently expanded tasks. Of
course, the tasks who don't have the tag are not listed because they are
not in the treeview so not considered as expanded.

My proposition :
- Keep the current "restore_expand" mechanism which is good.
- Don't build the expanded list at every refresh but instead add/remove
task from it when the signal expanded_toggle is received.

>
> I'm taking charge of this bug since I will implement the storage the
> expanded state in the config file as well (see bug #322120).
>
> --
> The expanding state should be remembered accross refresh
> https://bugs.launchpad.net/bugs/313030
> You received this bug notification because you are a direct subscriber
> of the bug.
>

[Bertrand Rousseau (bertrand-rousseau)]

On Wed, Jan 28, 2009 at 9:35 AM, Lionel Dricot <email address hidden> wrote:
>
>> I guess we have to store the list of expanded tasks, and restore it at
>> each refresh. We could store this information in the configuration file,
>> as you ask.
>
> That's what we are doing now. This list is created at every refresh. If
> you switch to another tag, it will list the currently expanded tasks. Of
> course, the tasks who don't have the tag are not listed because they are
> not in the treeview so not considered as expanded.
>
> My proposition :
> - Keep the current "restore_expand" mechanism which is good.
> - Don't build the expanded list at every refresh but instead add/remove
> task from it when the signal expanded_toggle is received.

The problem is that the expand_toggle signal is sent from every row
when you use expand_all()

>>
>> I'm taking charge of this bug since I will implement the storage the
>> expanded state in the config file as well (see bug #322120).
>>
>> --
>> The expanding state should be remembered accross refresh
>> https://bugs.launchpad.net/bugs/313030
>> You received this bug notification because you are a direct subscriber
>> of the bug.
>>
>
> --
> The expanding state should be remembered accross refresh
> https://bugs.launchpad.net/bugs/313030
> You received this bug notification because you are a member of Gtg
> developers, which is the registrant for gtg.
>
> Status in Getting Things Gnome!: Fix Released
>
> Bug description:
> Because expand_all for each refresh can be annoying
>

--
Bertrand Rousseau
Place communale 1, 1450 Chastre, Belgium
e-mail : <email address hidden>
tel : [phone]

[Lionel Dricot (ploum-deactivatedaccount)]

> The problem is that the expand_toggle signal is sent from every row
> when you use expand_all()

Damn !

If there was an easy way to iterate through the row, we wouldn't need this
expand_all.

[Bertrand Rousseau (bertrand-rousseau)]

Reopening since actually now we don't store correctly the collapsed rows