Popup containing icons doesnt get closed on closing Edit Tag window

[Shikha Chowdhary]

Steps to reproduce
1)Select a tag to edit
2)In Edit tag window press 'Click to set icon'
3)A popup containing some icons opens.
4)Now close Edit tag window
5)The window disappears but the popup remains

[Sagar Ghuge (ghugesss)]

Also one more problem with this.

On loosing foucs popup doesnt hide.

Expected Feature : on foucs-out popup should hide.

[Shikha Chowdhary (shikhachowdhary28)]

Should both these bugs be solved in a single branch?I have solved the first issue.Should I solve the second issue in this same branch?

[Nimit Shah (nimit-svnit)]

Hi Sikha,
Fix both these issues in the same branch.

Nimit Shah

On Tue, Mar 18, 2014 at 2:50 AM, Shikha Chowdhary <
<email address hidden>> wrote:

> Should both these bugs be solved in a single branch?I have solved the
> first issue.Should I solve the second issue in this same branch?
>
> --
> You received this bug notification because you are subscribed to Getting
> Things GNOME!.
> Matching subscriptions: bugs
> https://bugs.launchpad.net/bugs/1293104
>
> Title:
> Popup containing icons doesnt get closed on closing Edit Tag window
>
> Status in Getting Things GNOME!:
> New
>
> Bug description:
> Steps to reproduce
> 1)Select a tag to edit
> 2)In Edit tag window press 'Click to set icon'
> 3)A popup containing some icons opens.
> 4)Now close Edit tag window
> 5)The window disappears but the popup remains
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/gtg/+bug/1293104/+subscriptions
>

[Parin Porecha (parinporecha)]

This bug is caused because the pointer position returned here - http://bazaar.launchpad.net/~gtg/gtg/trunk/view/head:/GTG/gtk/browser/tag_editor.py#L99 is wrong.

Why is it wrong ?
The issue is due to this line in tag_editor.py - http://bazaar.launchpad.net/~gtg/gtg/trunk/view/head:/GTG/gtk/browser/tag_editor.py#L159

According to the API - http://lazka.github.io/pgi-docs/api/Gdk_3.0/functions.html?highlight=pointer_grab#Gdk.pointer_grab , pointer_grab() is deprecated so that needs to be changed.

Hope this helps.

[Shikha Chowdhary (shikhachowdhary28)]

Parin : The icon-selector is displayed at the right position.As per the current implementation the selector is hidden when the user 'clicks' out of it.What is expected is that the selector should be hidden when ' cursor hovers out' of the window.I changed 'button-press-event' to 'leave-notify-event' in http://bazaar.launchpad.net/~gtg/gtg/trunk/view/head:/GTG/gtk/browser/tag_editor.py#L168 and it works.

[Parin Porecha (parinporecha)]

Shikha > Yes, the icon selector is displayed at the right position, it's out of the question.
But, no the selector should only be hidden when user 'clicks' out of it, and not on hovering.

Yes, you can change the event to make it work, but that would be a hack. You will still get the pointer position from the pointer_grab() function which should not be there. So, you need to replace that with the appropriate function.

[Shikha Chowdhary (shikhachowdhary28)]

Ok.I will look into it.

On Thu, Mar 20, 2014 at 12:38 AM, Parin Porecha <email address hidden>wrote:

> Shikha > Yes, the icon selector is displayed at the right position, it's
> out of the question.
> But, no the selector should only be hidden when user 'clicks' out of it,
> and not on hovering.
>
> Yes, you can change the event to make it work, but that would be a hack.
> You will still get the pointer position from the pointer_grab() function
> which should not be there. So, you need to replace that with the
> appropriate function.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1293104
>
> Title:
> Popup containing icons doesnt get closed on closing Edit Tag window
>
> Status in Getting Things GNOME!:
> In Progress
>
> Bug description:
> Steps to reproduce
> 1)Select a tag to edit
> 2)In Edit tag window press 'Click to set icon'
> 3)A popup containing some icons opens.
> 4)Now close Edit tag window
> 5)The window disappears but the popup remains
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/gtg/+bug/1293104/+subscriptions
>

[Shikha Chowdhary (shikhachowdhary28)]

I tried solving this by using http://lazka.github.io/pgi-docs/api/Gdk_3.0/classes/Device.html#Gdk.Device.grab .But the error says this function requires 7 arguments whereas the API states 6.I added 0 as the 7th argument and got to know that the first argument this function takes is Gdk.device . There is no method in Gdk.Device to set the source. I tried getting the device from http://lazka.github.io/pgi-docs/api/Gdk_3.0/classes/DeviceManager.html#Gdk.DeviceManager.get_client_pointer but the method again asks for 1 argument whereas the API states none.

Gdk.Device.grab(Gdk.DeviceManager.get_client_pointer(),self.get_window(),Gdk.GrabOwnership.NONE,True,Gdk.EventMask.ALL_EVENTS_MASK,None,0)
TypeError: get_client_pointer() takes exactly 1 argument (0 given)
TypeError: argument self: Expected Gdk.DeviceManager

I am stuck here.Please help

[Parin Porecha (parinporecha)]

Ask about this in #python on GimpNet