Port `make lint` to Python 3

Bug #1275226 reported by Chenxiong Qi on 2014-02-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Getting Things GNOME!
Low
Chenxiong Qi

Bug Description

Since code in trunk branch has been ported to Python 3, we also need to port `make lint` to Python 3, essentially to the pep8 and pyflakes utilities. As we know that command pep8 and pyflakes, that can be found from the directories in environment variable PATH, are used to check. In Fedora (that I'm running now), Python 2.x is still the default version of Python interpreter for system. Although pep8 and pyflakes for Python 3 exist, they are prefixed with python3- in command name individually, therefore they cannot be used along with lint target in make.

One possible solution is that define PEP8 and PYFLAKES macro, that default to pep8 and pyflakes and also allow developer to specify custom ones in the command line. For example,

$ make lint PEP8=python3-pep8 PYFLAKES=python3-pyflakes

Related branches

Chenxiong Qi (qcxhome) on 2014-02-01
summary: - Porting `make lint` to Python 3
+ Port `make lint` to Python 3
Chenxiong Qi (qcxhome) on 2014-02-01
Changed in gtg:
assignee: nobody → Chenxiong Qi (qcxhome)
Chenxiong Qi (qcxhome) on 2014-02-01
Changed in gtg:
status: New → In Progress
Parin Porecha (parinporecha) wrote :

Merged in revision 1349

Changed in gtg:
status: In Progress → Fix Committed
importance: Undecided → Low
milestone: none → 0.3.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers