due label in task editor says "Due for" should say "Due on"

Bug #1248185 reported by Bryan Thomas on 2013-11-05
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Getting Things GNOME!
Low
Pawan Hegde

Bug Description

Due on text label says "Due for"

Related branches

Bryan Thomas (racerx) wrote :

Here is a screenshot.

Bryan Thomas (racerx) wrote :

And a patch

I did not update the translation files

Parin Porecha (parinporecha) wrote :

Thanks Bryan for reporting the bug, and also providing a patch for it.

I searched right now for the right label to show. As English is not my first language, I'd like to have your and others' opinions on this. Which is the most apt label to show ? - 'Due'/'Due on'/'Due for' ?

Yes, 'Due for' doesn't seem right, but I don't know if 'Due' is better or 'Due on' is.

Please comment your suggestions below

Bryan Thomas (racerx) wrote :

NP. So if we changed it to just "Due" then we should also change "Starting on" to "Start"

So in these contexts you have larger sentences that are implied:

1. This task is starting on 11/5/2013
2. This task is due on 11/6/2012

To keep the UI compact and succint my personal preference is:

Start
Due

Bryan Thomas (racerx) wrote :

patch to fix both labels

Changes Starting on Label in Task Editor to Start
Changes Due for Label in Task Editor to Due

Bryan Thomas (racerx) wrote :

Sorry above patch still has Due for in it.

Nimit Shah (nimit-svnit) wrote :

I would go with 'Due on'.

tags: added: love
Pawan Hegde (h-pawan) wrote :

I am interested in fixing this bug. The way I see it, "Starts on" and "Due on" would be the correct labels here, since we are referring to a task and stating its start and end dates. Think of it as "Task starts on" and "Task is due on". Is that fine?

Bryan Thomas (racerx) wrote :

Here is the updated patch

contents:

changed labels to

due on
start on

Bryan Thomas (racerx) wrote :

I guess starts on is the right label

Nimit Shah (nimit-svnit) wrote :

Hi,
When you wish to work on a bug, please assign it to yourself to prevent conditions like this :)

Changed in gtg:
importance: Undecided → Low
Pawan Hegde (h-pawan) on 2014-02-20
Changed in gtg:
assignee: nobody → Pawan Hegde (h-pawan)
Pawan Hegde (h-pawan) wrote :

I will keep that in mind next time. I didn't even know I could just assign myself. :D

I followed the guide at https://wiki.gnome.org/Apps/gtg/contributing. Maybe this info needs to go there too. :)

Pawan Hegde (h-pawan) wrote :

And going by the guide, I had created a branch and assigned you to review it. Is that the preferred way to do bugfixes, or should I have sent a patch instead?

Creating a branch is a proper way. I know that you had assigned it to me
and I will review it soon!

Nimit Shah

On Thu, Feb 20, 2014 at 2:28 PM, Pawan Hegde <email address hidden>wrote:

> And going by the guide, I had created a branch and assigned you to
> review it. Is that the preferred way to do bugfixes, or should I have
> sent a patch instead?
>
> ** Attachment added: "Change Datebox labels to "Starts on" and "Due on"
> respectively"
>
> https://bugs.launchpad.net/gtg/+bug/1248185/+attachment/3987887/+files/datebox-label-changed.txt
>
> --
> You received this bug notification because you are subscribed to Getting
> Things GNOME!.
> Matching subscriptions: bugs
> https://bugs.launchpad.net/bugs/1248185
>
> Title:
> due label in task editor says "Due for" should say "Due on"
>
> Status in Getting Things GNOME!:
> New
>
> Bug description:
> Due on text label says "Due for"
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/gtg/+bug/1248185/+subscriptions
>

Nimit Shah (nimit-svnit) on 2014-02-20
Changed in gtg:
status: New → Fix Committed
milestone: none → 0.3.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers