GTG

Drop "Ctrl+E" as "Edit Task" shortcut in the documentation

Bug #1008241 reported by Radina Matic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GTG
Fix Released
Low
Radina Matic
GTG 0.3 "make it stable"

Bug Description

I was checking all the shortcuts for the user docs and found that "Ctrl+E - Edit Task" (as listed on https://live.gnome.org/gtg/documentation) actually does nothing...

Maybe this needs rethinking because if all that "Edit Task" shortcut does is to open the task for editing, than the ENTER shortcut (Show Task Editor Window) will do, correct?

Cheers,
Radina

Related branches

lp:~gtg-user/gtg/plugins-preferences-separation
Bertrand Rousseau (community): Approve (run)
Diff: 1996 lines (+850/-866)
10 files modified
GTG/gtk/__init__.py (+1/-0)
GTG/gtk/backends_dialog.glade (+0/-1)
GTG/gtk/backends_dialog/__init__.py (+2/-2)
GTG/gtk/browser/browser.py (+7/-6)
GTG/gtk/browser/taskbrowser.glade (+27/-12)
GTG/gtk/manager.py (+8/-5)
GTG/gtk/plugins.glade (+227/-0)
GTG/gtk/plugins.py (+322/-0)
GTG/gtk/preferences.glade (+154/-427)
GTG/gtk/preferences.py (+102/-413)
Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote :

It seems to me that a Ctrl+E shortcut dedicated to show task edition is useless. I would recommend to drop it from the documentation. Only ENTER should be documented as such.

On a side not, ENTER should thus also be mentioned as an accelerator for "Edit" in the Task Menu. (but this for another bug)

Changed in gtg:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Radina Matic (radina-matic)
summary: - Ctrl+E - Edit Task shortcut working?
+ Drop "Ctrl+E" as "Edit Task" shortcut in the documentation
Revision history for this message
Radina Matic (radina-matic) wrote :

Ok, I updated the documentation and the wiki.

Cheers,
R.

Revision history for this message
Izidor Matušov (izidor) wrote :

Radina updated the documentation, I checked the code and initial tasks, there is nothing about Ctrl+E. Closing as fixed :)

Changed in gtg:
status: Confirmed → Fix Committed
milestone: none → 0.3
Revision history for this message
Izidor Matušov (izidor) wrote :

I was wrong, there was still code for CTRL+e callback. It was removed in the related branch. Reopening until it is merged.

Changed in gtg:
status: Fix Committed → In Progress
Izidor Matušov (izidor)
Changed in gtg:
status: In Progress → Fix Committed
Bertrand Rousseau (bertrand-rousseau)
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.