"Setup Sync. Services" window has undescriptive title "gtg"

Bug #1002067 reported by Wolter Hellmund on 2012-05-20
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Getting Things GNOME!
Low
Alan Gomes Alvino

Bug Description

This is a very minor bug, but still important. The title says it all: When you open the "Setup Sync. Services" window, it is created with a title "gtg", which looks like a placeholder that was never properly replaced.

Related branches

Izidor Matušov (izidor) wrote :

Great catch! Would you like to change it to something more meaningful? Easy way to have a commit in GTG :)

tags: added: love
Changed in gtg:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 0.3

Well there doesn't seem to be a standard way in which an application's
secondary window's titles are written, but I think keeping the following
format is an elegant solution: <application name> - <window title>.
The <application name> is a variable already defined in this case (I
would think it is "Getting Things GNOME!"), and a good <window title>
would be "Synchronization Services".

However, if you take a look at GTG's main window, the format <window
title> - <application name> is used; which I think is also good and
worth sticking to.

In other words, "Synchronization Services - Getting Things GNOME!" would
be my candidate :)

Should I create a branch in the ~gtg-user group to fix this bug?

Changed in gtg:
status: Confirmed → In Progress
Alan Gomes Alvino (alangalvino) wrote :

Hi I've solved this 'bug' adding a constant in BackendsDialog and setting the title variable of the self.dialog to "Synchronization Services - Getting Things GNOME!". The branch is here https://code.launchpad.net/~gtg-user/gtg/bugfix-1002067.

Changed in gtg:
assignee: nobody → Alan Gomes Alvino (alangalvino)
Wolter Hellmund (wolterh) wrote :

Thanks for solving the bug Alan!

Izidor Matušov (izidor) wrote :

Thanks for your contribution! Fixed in rev. 1183.

Changed in gtg:
status: In Progress → Fix Committed
Alan Gomes Alvino (alangalvino) wrote :

Sorry for my 'newbie' mode!! I'will follow the branch step!! And sorry for propose a solution(I put the code in python when i have to put in .glade file) without ask!

Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers