apic_mapping: External segment IP set for shadow L3-outs

[Robert Kukura]

While investigating https://bugs.launchpad.net/group-based-policy/+bug/1509458, I discovered that GroupPolicyDbPlugin._set_ess_for_l3p() gets called six times during creation of an L3Policy with an implicit ExternalSegment, and that two different IP addresses get passed to it for the same L3Policy. I filed https://bugs.launchpad.net/group-based-policy/+bug/1522554 to cover duplicate calls to _set_ess_for_l3p() originating from create_l3_policy_postcommit() and update_l3_policy_postcommit(). This bug addresses the unnecessary calls to _set_ess_for_l3p() resulting from ApicMappingDriver._plug_l3p_to_es() recursively calling itself to process shadow L3-outs. When called recursively, with is_shadow=True, it should not call L3PolicyContext.set_external_fixed_ips(), which results in an unnecessary call to _set_ess_for_l3p().

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/254360
Committed: https://git.openstack.org/cgit/openstack/group-based-policy/commit/?id=d710a82b510a00ad897cfdd1cd5365996a31cdb9
Submitter: Jenkins
Branch: master

commit d710a82b510a00ad897cfdd1cd5365996a31cdb9
Author: Amit Bose <email address hidden>
Date: Mon Dec 7 11:48:22 2015 -0800

    [APIC mapping] Set external IP for L3Policy only once

    Remove the redundant call to set external fixed-IP
    for the L3Policy when creating shadow L3Out on APIC.

    Closes-Bug: 1522613

    Change-Id: I0b92e0497fd1fbefc8c6e89892f20523b3c3ad43
    Signed-off-by: Amit Bose <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/254930

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/254931

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/254930
Committed: https://git.openstack.org/cgit/openstack/group-based-policy/commit/?id=63fb874c1045b29858d4baf0a5e31d2ddea2bd19
Submitter: Jenkins
Branch: stable/kilo

commit 63fb874c1045b29858d4baf0a5e31d2ddea2bd19
Author: Amit Bose <email address hidden>
Date: Mon Dec 7 11:48:22 2015 -0800

    [APIC mapping] Set external IP for L3Policy only once

    Remove the redundant call to set external fixed-IP
    for the L3Policy when creating shadow L3Out on APIC.

    Closes-Bug: 1522613

    Change-Id: I0b92e0497fd1fbefc8c6e89892f20523b3c3ad43
    Signed-off-by: Amit Bose <email address hidden>
    (cherry picked from commit d710a82b510a00ad897cfdd1cd5365996a31cdb9)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/254931
Committed: https://git.openstack.org/cgit/openstack/group-based-policy/commit/?id=99a3093ca13f31349de14509ea8779af3b3ed745
Submitter: Jenkins
Branch: stable/juno

commit 99a3093ca13f31349de14509ea8779af3b3ed745
Author: Amit Bose <email address hidden>
Date: Mon Dec 7 11:48:22 2015 -0800

    [APIC mapping] Set external IP for L3Policy only once

    Remove the redundant call to set external fixed-IP
    for the L3Policy when creating shadow L3Out on APIC.

    Closes-Bug: 1522613

    Change-Id: I0b92e0497fd1fbefc8c6e89892f20523b3c3ad43
    Signed-off-by: Amit Bose <email address hidden>
    (cherry picked from commit d710a82b510a00ad897cfdd1cd5365996a31cdb9)
    (cherry picked from commit 63fb874c1045b29858d4baf0a5e31d2ddea2bd19)