[apic-mapping] Issues with L2 policy name change with GBP

[Biju Varghese]

Trying to edit the name of the L2 policy via GBP and I see that the GBP gets updated however the neutron and the APIC is not updated with the new name.

Editing the l2 policy name BV-L2-Policy-1.
 [root@sg1-controller ~(keystone_admin)]# gbp l2policy-list | grep -i bv
| 191f7ab2-4e96-4080-8057-86457683d297 | BV-L3-Policy-3 | | 29ac0635-61e1-41e2-8b86-3289cd9061ad |
| 9d7bc2ca-a363-407f-a4eb-bd86dfd5ef27 | BV-L2-Policy-2 | | 29ac0635-61e1-41e2-8b86-3289cd9061ad |
| e590dc59-d49e-4540-8182-7e4d1ff210b9 | BV-L2-Policy-1 | | 29ac0635-61e1-41e2-8b86-3289cd9061ad |
[root@sg1-controller ~(keystone_admin)]#

[root@sg1-controller ~(keystone_admin)]#
[root@sg1-controller ~(keystone_admin)]# neutron net-list | grep -i BV
| 4f0bf6a7-09cd-4c2b-a11f-e09ee0b28b20 | l2p_BV-L3-Policy-3 | |
| 8353c114-4ba8-47ac-8054-6118ffb2edc8 | l2p_BV-L2-Policy-2 | |
| bfe33356-ebc8-4add-910b-f6e0d82cc5e3 | l2p_BV-L2-Policy

Name update on the GBP is successful, however this leads to other issues.
Deleting the l2 policy from GBP not deleting from APIC. Had to manually delete from the APIC
Also saw an issue while creating a PTG with the same L3 policy, successfully updated the GBP, however on the APIC the EPG status shows as failed to apply. Without the name change of the L2 policy no issues were seen.

Once the name change happens, a lot of objects were out of sync wrt APIC and neutron. Had issues with l2 policy delete, creation of PTG . Basically anything referencing the l2policy had issues.
We should give some stern warning when trying to do the name change option.