Update PTG fails with PortNotFound

Bug #1467159 reported by Sumit Naiksatam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Group Based Policy
Fix Released
High
Sumit Naiksatam

Bug Description

The following code block:
https://github.com/stackforge/group-based-policy/blob/master/gbpservice/neutron/services/grouppolicy/drivers/resource_mapping.py#L2195-L2200

does not check if there is no port associated with a PT, and the update fails if there is none. Probably a check similar to that in the disassociate SG code block:
https://github.com/stackforge/group-based-policy/blob/master/gbpservice/neutron/services/grouppolicy/drivers/resource_mapping.py#L2213-L2220

should be performed.

Revision history for this message
Robert Kukura (rkukura) wrote :

As I recall, the resource_mapping driver was written with the expectation that PTs always have valid ports. Given that race conditions, failures during postcommit, and port deletion using neutron are all possible, I agree the code should be defensive, and the two cited cases should be handled similarly.

Changed in group-based-policy:
status: New → Confirmed
Changed in group-based-policy:
importance: Undecided → High
assignee: nobody → Sumit Naiksatam (snaiksat)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to group-based-policy (master)

Fix proposed to branch: master
Review: https://review.openstack.org/208189

Changed in group-based-policy:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to group-based-policy (master)

Reviewed: https://review.openstack.org/208189
Committed: https://git.openstack.org/cgit/stackforge/group-based-policy/commit/?id=a37edd88ef885620156c2e08a077655248efd24e
Submitter: Jenkins
Branch: master

commit a37edd88ef885620156c2e08a077655248efd24e
Author: Sumit Naiksatam <email address hidden>
Date: Sat Aug 1 23:27:02 2015 -0700

    Check for port association before PT update

    Change-Id: Ic22e981bfd137b87592ba5450fe7cbc3a393c608
    Closes-bug: 1467159

Changed in group-based-policy:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to group-based-policy (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/209261

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to group-based-policy (stable/juno)

Reviewed: https://review.openstack.org/209261
Committed: https://git.openstack.org/cgit/stackforge/group-based-policy/commit/?id=2f208d01e32307a1e55054010adf23fb77d8ab2f
Submitter: Jenkins
Branch: stable/juno

commit 2f208d01e32307a1e55054010adf23fb77d8ab2f
Author: Sumit Naiksatam <email address hidden>
Date: Sat Aug 1 23:27:02 2015 -0700

    Check for port association before PT update

    Change-Id: Ic22e981bfd137b87592ba5450fe7cbc3a393c608
    Closes-bug: 1467159
    (cherry picked from commit a37edd88ef885620156c2e08a077655248efd24e)

tags: added: in-stable-juno
Changed in group-based-policy:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.