During the creation of GBP L3Policy Object, we need to implement validity check for the attribute values.
For example: today any ipaddress is accepted as the ip-pool, including the invalid ones as 0.0.0.0/0 and 255.255.255.255/32.
The above should report error instead of awaiting on the backend neutron to fail in allocating ip-address from an invalid ip-pool.
User should be notified ahead on his attempt of creating an ip-pool with invalid address, instead of hitting the error later down the line
test@localhost:~/devstack$ gbp l3policy-create A --ip-pool 255.255.255.255/32
Created a new l3_policy:
+----------------------+--------------------------------------+
| Field | Value |
+----------------------+--------------------------------------+
| description | |
| external_segments | {} |
| id | 07779195-261d-4f40-b07e-1fa27adbefef |
| ip_pool | 255.255.255.255/32 |
| ip_version | 4 |
| l2_policies | |
| name | A |
| routers | bd35a374-4c08-439f-9e4e-5247fe8ed3e1 |
| shared | False |
| subnet_prefix_length | 24 |
| tenant_id | b3094e3ded7e4d6ea7b91b3641214a7a |
+----------------------+--------------------------------------+
test@localhost:~/devstack$
test@localhost:~/devstack$
test@localhost:~/devstack$ gbp l3policy-delete A
Deleted l3_policy: A
test@localhost:~/devstack$
test@localhost:~/devstack$ gbp l3policy-create A --ip-pool 0.0.0.0/0
Created a new l3_policy:
+----------------------+--------------------------------------+
| Field | Value |
+----------------------+--------------------------------------+
| description | |
| external_segments | {} |
| id | 09e55ad4-b265-428a-978e-467484c786a1 |
| ip_pool | 0.0.0.0/0 |
| ip_version | 4 |
| l2_policies | |
| name | A |
| routers | de491a67-c231-4d68-a65e-5d895e4f9d74 |
| shared | False |
| subnet_prefix_length | 24 |
| tenant_id | b3094e3ded7e4d6ea7b91b3641214a7a |
+----------------------+--------------------------------------+
test@localhost:~/devstack$
Fix proposed to branch: master
Review: https:/