Missing templates when user re-login while filling forms

Bug #1710852 reported by Aleš Křivák
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Group Based Policy UI
Fix Released
Undecided
Marek Lyčka

Bug Description

GPB UI currently contains only templates for forms/workflows loaded via ajax (templates starting with _) but not version used when form is rendered on separate page (e. g. /project/policytargets/addpolicy_target). User can end on these pages after re-login (i. e. when session expires while user is filling form) or when opening button in new tab using middle click.

Changed in group-based-policy-ui:
assignee: nobody → Aleš Křivák (aleskrivak)
Changed in group-based-policy-ui:
status: New → In Progress
Changed in group-based-policy-ui:
assignee: Aleš Křivák (aleskrivak) → Marek Lyčka (mareklycka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to group-based-policy-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/502223

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to group-based-policy-ui (master)

Reviewed: https://review.openstack.org/493617
Committed: https://git.openstack.org/cgit/openstack/group-based-policy-ui/commit/?id=268ae1259ab50b77e89e54a11392bcd2a2249e4f
Submitter: Jenkins
Branch: master

commit 268ae1259ab50b77e89e54a11392bcd2a2249e4f
Author: Aleš Křivák <email address hidden>
Date: Mon Aug 14 19:06:51 2017 +0200

    Update templates in policytargets section.

    Templates used throughout GBP UI were not properly updated
    for several OpenStack releases. This update removes unused templates
    and reduces unnecessary complexity. Additionally, this fixes problems
    with missing non-ajax version of templates, that breaks standalone
    rendering of forms and workflows (e. g. when opened in new tab or after
    re-login when session expires during while working with forms).

    This commit fixes ony policytargets section.

    Partial-Bug: #1710852
    Co-Authored-By: Marek Lycka <email address hidden>
    Change-Id: I4f8f6cef04fd514eccb428e8a89cc030ae99cb2a

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/502223
Committed: https://git.openstack.org/cgit/openstack/group-based-policy-ui/commit/?id=f3048c76ec6a17e615b025189ef0393584a6c4c7
Submitter: Jenkins
Branch: master

commit f3048c76ec6a17e615b025189ef0393584a6c4c7
Author: Marek Lycka <email address hidden>
Date: Fri Sep 8 15:02:43 2017 +0200

    Removes and simplifies GBPUI templates

    Removes unused templates and simplifies remaining templates and views by extracting common logic
    in the same way as the previous partial patch for this bug did.

    Change-Id: I832a7ab88e99103b9e6abdfd8be44fcd8bee1a11
    Closes-Bug: 1710852
    Co-Authored-By: <email address hidden>

Changed in group-based-policy-ui:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.