Updating Policy Classifier Fails when attempt to update direction

Bug #1589738 reported by mudit
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Group Based Policy UI
Fix Released
High
ank

Bug Description

In order to reproduce, please follow these steps:
In a Kilo Setup
1. Create a Policy Classifier with name ICMP-2 with 'Direction = in'
2. After successful creation, edit the same Policy Classifier and attempt to change the Direction to 'Bi'.
3. When we click on the Submit button, we get an error and the operation fails.
Error:
Danger: There was an error submitting the form. Please try again.

The Horizon Logs show the following Traceback:
2016-06-06 23:12:51,047 8764 ERROR django.request Internal Server Error: /dashboard/project/application_policy/updatepolicyclassifier/a0b1e954-9cb7-477e-8d0f-5556bbfa656a/
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 36, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 52, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 36, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 71, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 89, in dispatch
    return handler(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/generic/edit.py", line 215, in post
    return self.form_valid(form)
  File "/usr/lib/python2.7/site-packages/horizon/forms/views.py", line 173, in form_valid
    exceptions.handle(self.request)
  File "/usr/lib/python2.7/site-packages/horizon/exceptions.py", line 364, in handle
    six.reraise(exc_type, exc_value, exc_traceback)
  File "/usr/lib/python2.7/site-packages/horizon/forms/views.py", line 170, in form_valid
    handled = form.handle(self.request, form.cleaned_data)
  File "/usr/lib/python2.7/site-packages/gbpui/panels/application_policy/forms.py", line 292, in handle
    redirect=url)
  File "/usr/lib/python2.7/site-packages/horizon/exceptions.py", line 364, in handle
    six.reraise(exc_type, exc_value, exc_traceback)
  File "/usr/lib/python2.7/site-packages/gbpui/panels/application_policy/forms.py", line 273, in handle
    protocol = context.get('protocol').lower()
AttributeError: 'NoneType' object has no attribute 'lower'
2016-06-06 23:13:08,972 8763 ERROR django.request Internal Server Error: /dashboard/project/application_policy/updatepolicyclassifier/a0b1e954-9cb7-477e-8d0f-5556bbfa656a/
Traceback (most recent call last):

Changed in group-based-policy-ui:
milestone: none → next
assignee: nobody → ank (ank.b)
importance: Undecided → High
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to group-based-policy-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/327468

Changed in group-based-policy-ui:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to group-based-policy-ui (master)

Reviewed: https://review.openstack.org/327468
Committed: https://git.openstack.org/cgit/openstack/group-based-policy-ui/commit/?id=47d2a569aa60a34e6f74934dc86c3dc684384b50
Submitter: Jenkins
Branch: master

commit 47d2a569aa60a34e6f74934dc86c3dc684384b50
Author: ank <email address hidden>
Date: Thu Jun 9 10:42:15 2016 +0530

    Policy Classifier update is failing

    Change-Id: I142b9f02705be21141336a751a9204322ae93d98
    Closes-Bug: #1589738

Changed in group-based-policy-ui:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to group-based-policy-ui (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/327879

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to group-based-policy-ui (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/327880

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to group-based-policy-ui (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/327882

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to group-based-policy-ui (stable/liberty)

Reviewed: https://review.openstack.org/327880
Committed: https://git.openstack.org/cgit/openstack/group-based-policy-ui/commit/?id=8a352ab5bb017f495161f808780b20cf7284231c
Submitter: Jenkins
Branch: stable/liberty

commit 8a352ab5bb017f495161f808780b20cf7284231c
Author: ank <email address hidden>
Date: Thu Jun 9 10:42:15 2016 +0530

    Policy Classifier update is failing

    Change-Id: I142b9f02705be21141336a751a9204322ae93d98
    Closes-Bug: #1589738
    (cherry picked from commit 47d2a569aa60a34e6f74934dc86c3dc684384b50)

tags: added: in-stable-liberty
tags: added: in-stable-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to group-based-policy-ui (stable/kilo)

Reviewed: https://review.openstack.org/327882
Committed: https://git.openstack.org/cgit/openstack/group-based-policy-ui/commit/?id=8f059cdac1e4a9077a71691fe8309d6dffbb22d1
Submitter: Jenkins
Branch: stable/kilo

commit 8f059cdac1e4a9077a71691fe8309d6dffbb22d1
Author: ank <email address hidden>
Date: Thu Jun 9 10:42:15 2016 +0530

    Policy Classifier update is failing

    Change-Id: I142b9f02705be21141336a751a9204322ae93d98
    Closes-Bug: #1589738
    (cherry picked from commit 47d2a569aa60a34e6f74934dc86c3dc684384b50)

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to group-based-policy-ui (stable/mitaka)

Reviewed: https://review.openstack.org/327879
Committed: https://git.openstack.org/cgit/openstack/group-based-policy-ui/commit/?id=cdfcd5c5ef58b025c302ac872521446cb604d68a
Submitter: Jenkins
Branch: stable/mitaka

commit cdfcd5c5ef58b025c302ac872521446cb604d68a
Author: ank <email address hidden>
Date: Thu Jun 9 10:42:15 2016 +0530

    Policy Classifier update is failing

    Change-Id: I142b9f02705be21141336a751a9204322ae93d98
    Closes-Bug: #1589738
    (cherry picked from commit 47d2a569aa60a34e6f74934dc86c3dc684384b50)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.