[BPO] Please backport sdbus-cpp 0.8.3-4 (universe) from impish

[Luca Boccassi]

[Impact]

There is an upcoming Azure-related project that would like to support
Ubuntu 20.04 LTS out of the box, and one of the requirements is the
sdbus-cpp library.
The library is available in hirsute and bullseye, but not in focal.
It would be great if it could be uploaded to focal-backports, so
that it can be used out of the box. The alternative for the project
team would be to vendor the dependency, but this would also apply
to newer releases where the library is available, which means the
security and maintainability would take a hit.

[Scope]

Backport from 21.10 impish to 20.04 focal-backports.
So far Jammy is on the same version as impish - the new one there needs some fixes. But clearly later on we might re-upload a new verions once this has settled in Jammy.

[Other Info]
The only change needed to get a working build is to downgrade debhelper-compat from 13 to 12 in debian/control. Everything else works out of the box.

PPA build:

https://launchpad.net/~bluca/+archive/ubuntu/sdbus-cpp/+packages

--- sponsoring ---

[by cpaelzer]

Thanks for the link to [0].
The new rules are not much different to the past IMHO, checking all of this against them ...

- Responsibilities of the Backporter
  - Prepare the package - (Lucas proposed content was fine already)
  - Reviewed, the changes for the BP are really minimal
- Testing the Backport
  - Done (already by Luca before based on the PPA)
- Functionality of the Backported Package
  - This was tested on Lucas PPA (identical to the sponsored upload)
    already in regard to [1] which is one of the use cases
    utilizing the library
  - It also installs fine in my tests
  - Build time tests are present and passed as seen in [4] and similar
    for all architectures
  - Autopkgtest are not present, but would make more sense on an
    app using the lib which (so far) is not in Focal
  - No existing Dependencies or build-dependencies to sdbus-cpp
    that we'd affect
- Future Maintenance of the Backport
  - Luca/Azure will watch this and let us know and help if there
    are new uploads needed.
    - I have and will show Luca how to subscribe to the package on
      LP to see potential related bug reports
  - I've also imported the package to git-ubuntu for better
    maintenance/tracking
    - the backport can be seen there as well [3]

I've done another set of test builds [2] (on all architectures this time) and installs, but it really is a) simple and b) seems to work just fine. A few changes to the changelog and update-maintainer is all that I added to be more formally-correct.

Further testing examples were executed and logs added by Luca - see comment 7.

[0]: https://wiki.ubuntu.com/UbuntuBackports#Prepare_and_upload_the_package
[1]: https://techcommunity.microsoft.com/t5/microsoft-endpoint-manager-blog/microsoft-endpoint-manager-adds-management-and-compliance-checks/ba-p/2902346
[2]: https://launchpad.net/~paelzer/+archive/ubuntu/sdbus-cpp-focal
[3]: https://git.launchpad.net/~paelzer/ubuntu/+source/sdbus-cpp?h=backport-lp-1916068
[4]: https://launchpadlibrarian.net/569547426/buildlog_ubuntu-focal-arm64.sdbus-cpp_0.8.3-4~bpo20.04.1_BUILDING.txt.gz

[Dan Streetman (ddstreet)]

Hello,

the backports process has recently been updated, please see the new documentation:
https://wiki.ubuntu.com/UbuntuBackports

I'm closing this bug, but please feel free to open a new bug (or reopen this bug) using the new process, if appropriate.

[Luca Boccassi (bluca)]

I have updated the text and title, but I can't click on reopen for some reason, it's greyed out - could you please reopen it? Thanks!

[Dan Streetman (ddstreet)]

> I can't click on reopen for some reason

that's ok, we don't use the 'focal-backports' task anymore, the backports process just uses the ubuntu package for tracking now; since the bug is also (already) open against the sdbus-cpp package it's good.

Do you have upload rights to upload the backported package, or is a sponsor going to prepare and upload for you? I think @paelzer's team is doing the work for you right?

[Luca Boccassi (bluca)]

> Do you have upload rights to upload the backported package, or is a sponsor going to prepare and upload for you? I think @paelzer's team is doing the work for you right?

That's right - I do not have uploaders rights, so I just pushed to the linked PPA to show it works

[Dan Streetman (ddstreet)]

ack, i'll assign this to Christian then, he can delegate it if he wants, as his team is assigned this elsewhere i believe, and they'll need to use the proper new backports process

[Christian Ehrhardt  (paelzer)]

I (and the team) am only around helping Luca on this. It would be someone under Eric, but TBH pinging and finding this someone might add more stall to something already taking (too) long.
I'll use it as an exercise of the new backport process for myself.

[Luca Boccassi (bluca)]

Hopefully this is enough reg. testing: newer releases have an "examples" directory upstream. I've cloned the repository on Focal, added the package via my PPA, and built the examples locally (and stripped rpath to ensure they are using the system lib). The examples are working fine:

root@focal:/tmp/sdbus-cpp/b# cat /etc/os-release
NAME="Ubuntu"
VERSION="20.04 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal
root@focal:/tmp/sdbus-cpp/b# apt-cache policy libsdbus-c++0
libsdbus-c++0:
  Installed: 0.8.3-4~bpo20.04.1
  Candidate: 0.8.3-4~bpo20.04.1
  Version table:
 *** 0.8.3-4~bpo20.04.1 500
        500 http://ppa.launchpad.net/bluca/sdbus-cpp/ubuntu focal/main amd64 Packages
        100 /var/lib/dpkg/status
root@focal:/tmp/sdbus-cpp/b# ldd examples/obj-manager-server
 linux-vdso.so.1 (0x00007ffe0f8e2000)
 libsdbus-c++.so.0 => /lib/x86_64-linux-gnu/libsdbus-c++.so.0 (0x00007f378edfb000)
 libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f378ec1a000)
 libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f378ebff000)
 libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f378ea0d000)
 libsystemd.so.0 => /lib/x86_64-linux-gnu/libsystemd.so.0 (0x00007f378e960000)
 libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f378e811000)
 /lib64/ld-linux-x86-64.so.2 (0x00007f378ee48000)
 librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f378e804000)
 liblzma.so.5 => /lib/x86_64-linux-gnu/liblzma.so.5 (0x00007f378e7dd000)
 liblz4.so.1 => /lib/x86_64-linux-gnu/liblz4.so.1 (0x00007f378e7bc000)
 libgcrypt.so.20 => /lib/x86_64-linux-gnu/libgcrypt.so.20 (0x00007f378e69e000)
 libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f378e67b000)
 libgpg-error.so.0 => /lib/x86_64-linux-gnu/libgpg-error.so.0 (0x00007f378e658000)
root@focal:/tmp/sdbus-cpp/b# ./examples/obj-manager-server >/dev/null &
[1] 2639
root@focal:/tmp/sdbus-cpp/b#
root@focal:/tmp/sdbus-cpp/b# ./examples/obj-manager-client
/org/sdbuscpp/examplemanager/Planet1/Earth added: org.sdbuscpp.ExampleManager.Planet1
Earth has a population of 7874965825.

/org/sdbuscpp/examplemanager/Planet1/Trantor added: org.sdbuscpp.ExampleManager.Planet1
Trantor has a population of 40000000000.

/org/sdbuscpp/examplemanager/Planet1/Laconia added: org.sdbuscpp.ExampleManager.Planet1
Laconia has a population of 231721.

/org/sdbuscpp/examplemanager/Planet1/Earth removed: org.sdbuscpp.ExampleManager.Planet1

[Christian Ehrhardt  (paelzer)]

test install from PPA:

root@f:~# apt install libsdbus-c++-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following additional packages will be installed:
  libsdbus-c++-bin libsdbus-c++0
The following NEW packages will be installed:
  libsdbus-c++-bin libsdbus-c++-dev libsdbus-c++0
0 upgraded, 3 newly installed, 0 to remove and 0 not upgraded.
Need to get 126 kB of archives.
After this operation, 559 kB of additional disk space will be used.
Do you want to continue? [Y/n] Y
Get:1 http://ppa.launchpad.net/paelzer/sdbus-cpp-focal/ubuntu focal/main amd64 libsdbus-c++-bin amd64 0.8.3-4~bpo20.04.1 [50.3 kB]
Get:2 http://ppa.launchpad.net/paelzer/sdbus-cpp-focal/ubuntu focal/main amd64 libsdbus-c++0 amd64 0.8.3-4~bpo20.04.1 [51.8 kB]
Get:3 http://ppa.launchpad.net/paelzer/sdbus-cpp-focal/ubuntu focal/main amd64 libsdbus-c++-dev amd64 0.8.3-4~bpo20.04.1 [24.1 kB]
Fetched 126 kB in 0s (292 kB/s)
Selecting previously unselected package libsdbus-c++-bin.
(Reading database ... 48032 files and directories currently installed.)
Preparing to unpack .../libsdbus-c++-bin_0.8.3-4~bpo20.04.1_amd64.deb ...
Unpacking libsdbus-c++-bin (0.8.3-4~bpo20.04.1) ...
Selecting previously unselected package libsdbus-c++0.
Preparing to unpack .../libsdbus-c++0_0.8.3-4~bpo20.04.1_amd64.deb ...
Unpacking libsdbus-c++0 (0.8.3-4~bpo20.04.1) ...
Selecting previously unselected package libsdbus-c++-dev.
Preparing to unpack .../libsdbus-c++-dev_0.8.3-4~bpo20.04.1_amd64.deb ...
Unpacking libsdbus-c++-dev (0.8.3-4~bpo20.04.1) ...
Setting up libsdbus-c++0 (0.8.3-4~bpo20.04.1) ...
Setting up libsdbus-c++-bin (0.8.3-4~bpo20.04.1) ...
Setting up libsdbus-c++-dev (0.8.3-4~bpo20.04.1) ...
Processing triggers for libc-bin (2.31-0ubuntu9.2) ...

pkconfig, cmake integration all is in place.
This LGTM.

[Christian Ehrhardt  (paelzer)]

After review testing and preparing the backport-process details (in the bug description) I've sponsored this to focal-backports.

Assigning back to ddstreet - what would be the right assignee now, ~ubuntu-backporters, no-one, ... ? And out of curiosity - would that now show up in [1] or does focal-backports have a different place - if so where?
Maybe we could clarify those details in the wiki please?

[1]: https://launchpad.net/ubuntu/focal/+queue?queue_state=1&queue_text=

[Christian Ehrhardt  (paelzer)]

FYI: I see it in the NEW queue, which seems to be kind of usual/as-expected. But would -unapproved be the next queue then?

[Luca Boccassi (bluca)]

It seems it appeared here: https://launchpad.net/ubuntu/focal/+queue?queue_state=0&queue_text=

Thank you for your work!

[Dan Streetman (ddstreet)]

> Assigning back to ddstreet - what would be the right assignee now, ~ubuntu-backporters, no-one, ... ?

I added a discussion item for the next backporters meeting for this:
https://wiki.ubuntu.com/UbuntuBackports/Agenda#Discussion

> And out of curiosity - would that now show up in [1] or does focal-backports have a different place - if so where?
> [1]: https://launchpad.net/ubuntu/focal/+queue?queue_state=1&queue_text=

Normally, yes, a backported upload would appear in the Unapproved queue (queue_state=1), however as @bluca found, this one wound up in the New queue (queue_state=0) because the package didn't exist in focal.

I'm not sure that needs to be clarified on the wiki page, as it's standard behavior for the upload queues that I'd expect most sponsors to be familiar with, though anyone who normally uploads only into the 'Unapproved' queue might be confused about an uploading not showing up, so maybe the wiki could use a statement/hint; I added this to the backporters meeting discussion as well.

Thanks!

[Mattia Rizzolo (mapreri)]

So to conclude your questions: during the backporters meeting we decided that

(for now, of course things might change going forward if/when there is a need for them to change)

 * about assigning to somebody/someteam when it's ready for review: not required, as we just follow all bugs we are subscribed to that is not closed. (this is the same situation as of SRUs, FWIW).

 * about the upload queue: we consider that an implementation detail that uploaders need not be concerned with; you should already be receiving an email when the upload goes through, saying the upload was accepted (into whatever queue): that's enough of a "receipt" :)