tal:omit-tag should be processed before tal:attributes

Bug #430662 reported by Wichert Akkerman
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Zope 2
Invalid
Wishlist
Unassigned
Zope 3
Won't Fix
Undecided
Unassigned
grok
Won't Fix
Undecided
Unassigned
zope.tal
Invalid
Undecided
Unassigned

Bug Description

Currently TAL handles tal:attributes before tal:omit-tag. This has two problems: it is a needless performance penalty (omit-tag will cause the work done by attributes to be removed), and it can be problematic in situations where you want to omit the tag if it is not possible to set an attribute on it for some reason. This issue was also noticed by Tobias in 2008 (see the comment at the bottom of http://wiki.zope.org/ZPT/TALSpecification14#oop )

Revision history for this message
Wichert Akkerman (wichert) wrote :

For refererence: chameleon.zpt processes tal:omit-tag before tal:attributes, which has not revealed any problems.

Revision history for this message
Fred Drake (fdrake) wrote :

It doesn't help that the spec is inconsistent: The paragraph starting "The reasoning behind this ordering" states that attributes is processed last.

A new version of the spec (1.4.1) should be drafted by copying the current spec and clarifying this, and the implementation should be made to conform.

The current specification is in the ZPT wiki at http://wiki.zope.org/ZPT/TALSpecification14.

Tres Seaver (tseaver)
Changed in zope3:
status: New → Won't Fix
Revision history for this message
Fred Drake (fdrake) wrote :

Tres: Please justify the "Won't Fix".

I'd actually rather see it fixed.

Revision history for this message
Tres Seaver (tseaver) wrote :

This is "WONTFIX" for the Zope3 project, because we aren't going to be making any new releases of Zope3. Note that I made the bug relevant for the 'zope.tal' project, which is under the 'zopetoolkit' umbrella. This is the right home for the bug, because any fix for the bug is going to involve releasing a new version of zope.tal.

Revision history for this message
Fred Drake (fdrake) wrote : Re: [Bug 430662] Re: tal:omit-tag should be processed before tal:attributes

Gotcha; thanks.

/me is easily confused by Launchpad.

Changed in zope2:
importance: Undecided → Wishlist
status: New → Confirmed
Changed in grok:
status: New → Won't Fix
Revision history for this message
Colin Watson (cjwatson) wrote :

The zope.tal project on Launchpad has been archived at the request of the Zope developers (see https://answers.launchpad.net/launchpad/+question/683589 and https://answers.launchpad.net/launchpad/+question/685285). If this bug is still relevant, please refile it at https://github.com/zopefoundation/zope.tal.

Changed in zope.tal:
status: New → Invalid
Revision history for this message
Colin Watson (cjwatson) wrote :

The zope2 project on Launchpad has been archived at the request of the Zope developers (see https://answers.launchpad.net/launchpad/+question/683589 and https://answers.launchpad.net/launchpad/+question/685285). If this bug is still relevant, please refile it at https://github.com/zopefoundation/zope2.

Changed in zope2:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.