grokcore.view.meta.views.default_fallback_to_name can perhaps be removed

Bug #395061 reported by Reinout van Rees
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
grok
Fix Committed
Wishlist
Unassigned

Bug Description

default_fallback_to_name is not used in grokcore.view, but it is defined there. It is used in grok and in megrok.strictrequire

grokcore.security includes (and uses) its own copy. So perhaps grok and megrok.strictrequire can also just have their own two-line method instead of depending on grokcore.view?

Revision history for this message
Uli Fouquet (uli-gnufix) wrote :

I agree. If grokcore.view does not make any use of default_fallback_to_name, it should be removed there or marked deprecated.

For grok itself we might let it import from grokcore.security, then. Grok depends on grokcore.security anyway.

Similar for megrok.strictrequire.

Copying the function to the other packages is also an option, if there are no changes to it expected.

Changed in grok:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
trollfot (trollfot) wrote :

I did it in the current trunk (revision 109844). We may want to backport that into the 1.13 branch.

Changed in grok:
milestone: none → 1.3
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.