Grok should use versions from newer KGS

Bug #323544 reported by Martijn Faassen
4
Affects Status Importance Assigned to Milestone
grok
Fix Released
High
Unassigned

Bug Description

We need volunteers to compare the KGS list of Zope 3.40:

http://download.zope.org/zope3.4/3.4.0/versions.cfg

with Grok's list:

http://grok.zope.org/releaseinfo/grok-1.0a1.cfg

and then experiment with Grok (and the grokcore.* packages) using this list. Of course we need to supplement this list with versions for packages Grok depends on that Zope 3 itself doesn't (like the grokcore.* packages for instance). We also need to make sure we understand what's going on in case we already rely on a *newer* version of something that what's listed in KGS.

Changed in grok:
importance: Undecided → High
milestone: none → 1.0
status: New → Confirmed
Revision history for this message
Uli Fouquet (uli-gnufix) wrote :

As Michael "d2m" and I are working on a new grokcore package this weekend anyway (where we have to think about grok-dependencies as well), I'll also have a look at this issue.

Revision history for this message
Uli Fouquet (uli-gnufix) wrote :

As a first result below there is a comparison list of the grok 1.0.a1 versus KGS packages.

The only newer grok package seems to be `zope.app.publisher`. Many other packages did not pin a bugfix release but I think that should not cause trouble, should it?

Why does grok use a newer version of zope.app.publisher?

The version list
(where two version numbers appear, the first one is grok, the second from KGS):

GROK > KGS (1)
('zope.app.publisher', '3.5.1', '3.4.1')

GROK < KGS (42)
('ZODB3', '3.8', '3.8.1')
('zc.catalog', '1.2', '1.2.0')
('zodbcode', '3.4', '3.4.0')
('zope.app.authentication', '3.4.3', '3.4.4')
('zope.app.basicskin', '3.4', '3.4.0')
('zope.app.broken', '3.4', '3.4.0')
('zope.app.content', '3.4', '3.4.0')
('zope.app.dependable', '3.4', '3.4.0')
('zope.app.folder', '3.4', '3.4.0')
('zope.app.interface', '3.4', '3.4.0')
('zope.app.principalannotation', '3.4', '3.4.0')
('zope.app.renderer', '3.4', '3.4.0')
('zope.app.schema', '3.4', '3.4.0')
('zope.app.skins', '3.4', '3.4.0')
('zope.app.tree', '3.4', '3.4.0')
('zope.app.zapi', '3.4', '3.4.0')
('zope.app.zopeappgenerations', '3.4', '3.4.0')
('zope.component', '3.4', '3.4.0')
('zope.configuration', '3.4', '3.4.0')
('zope.contentprovider', '3.4', '3.4.0')
('zope.contenttype', '3.4', '3.4.0')
('zope.copypastemove', '3.4', '3.4.0')
('zope.datetime', '3.4', '3.4.0')
('zope.deferredimport', '3.4', '3.4.0')
('zope.deprecation', '3.4', '3.4.0')
('zope.dublincore', '3.4', '3.4.0')
('zope.event', '3.4', '3.4.0')
('zope.exceptions', '3.4', '3.4.0')
('zope.filerepresentation', '3.4', '3.4.0')
('zope.formlib', '3.4', '3.4.0')
('zope.hookable', '3.4', '3.4.0')
('zope.i18n', '3.4', '3.4.0')
('zope.lifecycleevent', '3.4', '3.4.0')
('zope.location', '3.4', '3.4.0')
('zope.minmax', '1.1', '1.1.0')
('zope.modulealias', '3.4', '3.4.0')
('zope.pagetemplate', '3.4', '3.4.0')
('zope.schema', '3.4', '3.4.0')
('zope.size', '3.4', '3.4.0')
('zope.structuredtext', '3.4', '3.4.0')
('zope.tales', '3.4', '3.4.0')
('zope.testing', '3.5.4', '3.5.6')

GROK ONLY: (12):
('Pygments', '0.8.1')
('grok', '1.0a1')
('grokcore.component', '1.5.1')
('grokcore.formlib', '1.1')
('grokcore.security', '1.0')
('grokcore.view', '1.2.1')
('grokcore.viewlet', '1.0')
('martian', '0.11')
('simplejson', '1.7.1')
('z3c.autoinclude', '0.2.2')
('z3c.flashmessage', '1.0')
('z3c.testsetup', '0.2.1')

There are also 71 packages only in KGS and 56 packages for which the version numbers are equal.

Revision history for this message
Uli Fouquet (uli-gnufix) wrote :

After all the only problematic package seems to be `zope.app.publisher`, which is newer in Grok than in the KGS. JW explained to me, that this is necessary to make use of the improved DirectoryResource implementation. The DirectoryResources of `grokcore.view` would be broken for multi-level directory structures with the KGS version.

I share JWs opinion, that this is a good reason to stick with zope.app.publisher 3.5.1.

Is it possible to depend on KGS in general except for `zope.app.publisher`?

Revision history for this message
Martijn Faassen (faassen) wrote : Re: [Bug 323544] Re: Grok should use versions from newer KGS

On Wed, Feb 18, 2009 at 3:09 PM, Uli Fouquet <email address hidden> wrote:
> I share JWs opinion, that this is a good reason to stick with
> zope.app.publisher 3.5.1.

+1

> Is it possible to depend on KGS in general except for
> `zope.app.publisher`?

Yes. We're not going to directly rely on the KGS list anyway; we'll
simply copy the recent KGS list into our Grok versions.cfg. We should
mark with a comment any packages that are in the KGS where we deviate
from it (zope.app.publisher), and place a comment on top saying that
we've based this list on KGS <version>.

Revision history for this message
Sylvain Viollon (thefunny) wrote :

It will be interesting to copy the Zope 3 version.cfg itself next to the Grok version.cfg (like version-zope3.cfg) and that the Grok version.cfg extend it, to add missing versions, or changing existing ones. Zope 2 people do it like for Zope 2.12, and I think it's nice since you have a small version.cfg which tells you what's are the difference between the official release of Zope 3. The downside is that you have one more file.

Revision history for this message
Jan Wijbrand Kolman (janwijbrand) wrote :

Sylvain, could you make a separate ticket out of your suggestion? Maybe targetting 1.0 or even 1.1?

For the upcomming 1.0a2 release I merely synced the version of the packages Grok has listed in its versions.cfg with the versions in KGS 3.4.0, excepting zope.app.publisher.

Grok's tests pass with this synced list.

Changed in grok:
status: Confirmed → Fix Committed
Changed in grok:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.