grokproject 1.0a1 generates faulty config when uppercase letters in projectname

Reported by Uli Fouquet on 2009-01-10
2
Affects Status Importance Assigned to Milestone
grok
Medium
Uli Fouquet
1.0
Medium
Uli Fouquet

Bug Description

There is a bug in current grokproject, which stops new users right from the beginning when they follow the tutorial.

When using uppercase chars in projectname, grokproject 1.0a1 generates zope.conf with faulty directory paths:

  (sandbox24)uli@pu:~/tmp/sandbox24$ ./bin/grokproject Sample
  Enter user (Name of an initial administrator user): grok
  Enter passwd (Password for the initial administrator user):
  Downloading info about versions...
  Creating directory ./Sample
  Downloading zc.buildout...
  Invoking zc.buildout...
  Develop: '/home/uli/tmp/sandbox24/Sample/.'
  Installing eggbasket.
  (sandbox24)uli@pu:~/tmp/sandbox24$ cd Sample/
  (sandbox24)uli@pu:~/tmp/sandbox24/Sample$ ./bin/paster serve etc/deploy.ini
  Traceback (most recent call last):
  ...
  IOError: [Errno 2] No such file or directory: '/home/uli/tmp/sandbox24/sample/parts/log/z3.log'

It turns out, that the logfile path (and other paths) were set as:

  /home/uli/tmp/sandbox24/sample/parts/log/z3.log

where it should have been:

  /home/uli/tmp/sandbox24/Sample/parts/log/z3.log

(uppercase 'S' in 'Sample').

This is especially bad, because 'Sample' is the projectname in the main tutorial. This means, that people following the tutorial will be stopped when creating a project.

It seems to me, that the error was caused by `template.py` where a wrong ``package_directory`` var is set: the package name is used, where the project name should be used (line 104).

Just commited a fix, that also normalizes the path (we don't want ``..`` and ``.`` in the paths, do we?). This should be reviewed by someone. Michael?

Tests are also still missing.

Uli Fouquet (uli-gnufix) wrote :
Uli Fouquet (uli-gnufix) wrote :

I'll finish this to be ready for release. Michael, if you want to take over, please do :-)

Changed in grok:
assignee: nobody → uli-gnufix
importance: Undecided → Medium
milestone: none → 1.0
status: New → Confirmed
status: Confirmed → In Progress
Uli Fouquet (uli-gnufix) on 2009-01-10
Changed in grok:
status: In Progress → Fix Committed

We should release an updated version of grokproject early next week
with this fix in there. This can be separate from a new Grok release,
though we should at least announce it on grok-dev and on the news on
grok.zope.org.

Uli and Michael, can you two take care of this? I've both given you
'owner' role on the grokproject package now. Please follow the
standard Grok release instructions before making a release.

> We should release an updated version of grokproject early next week
> with this fix in there. This can be separate from a new Grok release,
> though we should at least announce it on grok-dev and on the news on
> grok.zope.org.
>
> Uli and Michael, can you two take care of this? I've both given you
> 'owner' role on the grokproject package now. Please follow the
> standard Grok release instructions before making a release.

Sure, thank you. I'll contact Michael to get this done together.

Uli Fouquet (uli-gnufix) wrote :

This was fixed in grokproject 1.0a2.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers