eggbasket windows compatibility fix

Bug #315215 reported by Martijn Faassen
6
Affects Status Importance Assigned to Milestone
grok
Fix Released
High
Maurits van Rees
1.0
Fix Released
High
Maurits van Rees

Bug Description

The eggbasket downloader fails on Windows as it writes the downloaded tarball with 'w' instead of 'wb'. I've fixed that bit of the source code but there are two issues:

* when I run the tests, one of them fails:

File "..../README.txt", line 135, in README.txt
Failed example:
    print system(buildout)

* I do not have access to PyPI to upload a new version of the package.

Changed in grok:
assignee: nobody → maurits-vanrees
importance: Undecided → High
milestone: none → 1.0
status: New → Confirmed
Revision history for this message
Maurits van Rees (maurits-vanrees) wrote :

I see that Pypi access has been given.

Changeset 94692 fixes the test error for me. Hm, that fixes it for python2.4, but python2.5 still gives a problem. It seems that 2.5 does not understand the ellipsis in this test in line 135:

    >>> print system(buildout)
    ...
    Installing basket.
    <BLANKLINE>

Is there a difference between python2.4 and 2.5 in this regard.?

Revision history for this message
Martijn Faassen (faassen) wrote : Re: [Bug 315215] Re: eggbasket windows compatibility fix

> I see that Pypi access has been given.

I don't see any such thing? I just mailed you about it too.

Revision history for this message
Martijn Faassen (faassen) wrote :

On Mon, Jan 12, 2009 at 10:52 AM, maurits <email address hidden> wrote:
> Is there a difference between python2.4 and 2.5 in this regard.?

Not one that I'm aware of. Since Grok is officially supported on
Python 2.5 too, it'd be nice if we could get this fixed (though not
supremely urgent as it's just a test failure and not in the core).

Revision history for this message
Martijn Faassen (faassen) wrote :

I still have the issue. Taking it to its own bug, see bug #316489

Revision history for this message
Maurits van Rees (maurits-vanrees) wrote :

z3c.recipe.eggbasket now uses the 'wb' mode for Windows support and it has been released. Also see bug #316489

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.