grokcore.component contains old-style test setup

Bug #242353 reported by Philipp von Weitershausen
Affects Status Importance Assigned to Milestone
Fix Released
Uli Fouquet

Bug Description

grokcore.component was branched off the Grok trunk before the Grok trunk received the test setup make-over using z3c.testsetup. This stuff should be removed from grokcore.component and those test setup things that are still necessary (I imagine that, since grokcore.component doesn't have ftests, there isn't much needed) should be reincarnated using z3c.testsetup (like in Grok itself).

Revision history for this message
Uli Fouquet (uli-gnufix) wrote :

Right. I'll remove that stuff.

Changed in grok:
assignee: nobody → uli-gnufix
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Uli Fouquet (uli-gnufix) wrote :

Will there be bugfix releases for the releases 1.0 to 1.4? It seems, they all contain the old test setup. Or is it sufficient to fix that in the trunk?

Revision history for this message
Philipp von Weitershausen (philikon) wrote : Re: [Bug 242353] Re: grokcore.component contains old-style test setup

Just the trunk. There's no actual bug here (just cruft), so I don't
think we need bugfix releases.

Revision history for this message
Uli Fouquet (uli-gnufix) wrote :

Thanks! I removed the old stuff from the trunk (including tests).
What I didn't do yet: reincarnating the testsetup stuff as in grok. All the grok.testing reincarnation does, is offering the grok ftesting.zcml as fallback solution. grokcore.component has no ftests and so no ftesting.zcml to offer. Furthermore ZCML layers for functional tests will most probably be handled different in upcoming releases of z3c.testsetup. I therefore see not much sense in reincarnating the functionality in grokcore.component.People might be better off using z3c.testsetup directly, but I am open to objections.

Changed in grok:
status: In Progress → Fix Committed
Revision history for this message
Martijn Faassen (faassen) wrote :

Uli, I think not reincarnating the stuff as on the grok core is
exactly right. If people want to use z3c.testsetup with
grokcore.component, they can indeed combine them directly, and this
keeps grokcore.component cleaner.

Changed in grok:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.