code errors in import plugins
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Griffith |
Fix Committed
|
Medium
|
Michael |
Bug Description
when i surfed over import plugins to write my own for tellico imports (will submit the result separately) i noticed some odd code:
DVDProfiler.py
263 if details['genre'] > 2:
264 details['genre'] = details[
...
271 if details['studio'] > 2:
272 details['studio'] = details[
i'm somewhat sure there should be enclosed len():
263 if len(details[
264 details['genre'] = details[
...
271 if len(details[
272 details['studio'] = details[
as the clause is always true otherwise:
$ python
>>> "" > 2
True
>>> "1234" > 2
True
Changed in griffith: | |
milestone: | none → 0.13.1 |
Good find.
Fixed it with rev. 1612