map_cell0 doesn't actually run during nova upgrade

[Matt Riedemann]

Seen here:

http://logs.openstack.org/52/440652/2/check/gate-grenade-dsvm-neutron-ubuntu-xenial/74bea3f/logs/grenade.sh.txt.gz#_2017-03-02_20_38_14_429

2017-03-02 20:38:14.429 | + /opt/stack/new/grenade/projects/60_nova/upgrade.sh:main:79 : /usr/local/bin/nova-manage cell_v2 map_cell0 --database_connection
2017-03-02 20:38:16.615 | usage: nova-manage cell_v2 map_cell0 [-h]
2017-03-02 20:38:16.615 | [--database_connection <database_connection>]
2017-03-02 20:38:16.615 | nova-manage cell_v2 map_cell0: error: argument --database_connection: expected one argument

That's because we don't source lib/database from devstack first.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/442599

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/442599
Committed: https://git.openstack.org/cgit/openstack-dev/grenade/commit/?id=7c27948bb7c30f6c08695b65d2262211d1546aad
Submitter: Jenkins
Branch: master

commit 7c27948bb7c30f6c08695b65d2262211d1546aad
Author: Matt Riedemann <email address hidden>
Date: Tue Mar 7 11:15:15 2017 -0500

    Source lib/database when upgrading nova

    The "database_connection_url" function comes from
    lib/database in devstack. We need to source that before
    trying to call the function when upgrading nova.

    This wasn't caught because of the "|| true" on the map_cell0
    call. That can be removed because this nova change fixed it:

    aa7b6ebbb254f00fcb548832941ca9dbd3996d9f

    Change-Id: Iaa9340feb86df9a942642537474f0a433d8768b7
    Closes-Bug: #1670742