echo_summary is not found when running save-state script

[Adalberto Medeiros]

When grenade fails and calls the save-state script, there are some failures when calling the echo_summary function.

    + [[ 120 =~ setup-javelin ]]
    + echo_summary 'Saving current state information'
    + echo Saving current state information
    Saving current state information
    + /home/openstack/grenade/save-state
    *********************************************************************
    Begin /home/openstack/grenade/save-state
    *********************************************************************
    + echo_summary 'Sourcing base DevStack config'
    /home/openstack/grenade/save-state: line 42: echo_summary: command not found

The first two echo_summary are part of grenade.sh (where the function is defined) and the last one is part of save-state.

Since both scripts includes the functions defined in 'functions' utility, the best approach should be to move over the fuctions from 'grenade.sh' to 'functions'

[Dean Troyer (dtroyer)]

I'd remove the first echo_summary line in save-state and change the second one to just an echo if you think it is useful to have.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/27994

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/27994
Committed: http://github.com/openstack-dev/grenade/commit/99b0e3142d22f218575652b6808fcaf3a7d46a16
Submitter: Jenkins
Branch: master

commit 99b0e3142d22f218575652b6808fcaf3a7d46a16
Author: Dean Troyer <email address hidden>
Date: Wed May 1 15:36:16 2013 -0500

    Remove errant echo_summary calls

    Fixes bug 1161545

    Change-Id: Ic3979159bf76b87430c551b2e72323a3fe230cda