webapp queries carbon-cache for incorrect metric name if "base_fs_path" (storage.py:290) contains symlinks

Bug #913682 reported by Mike Kazantsev
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Graphite
Fix Released
High
Michael Leinartas

Bug Description

Graphite seem to be trying it's best to get real metric name from a symlinked one on WhisperFile class init, but cuts path components incorrectly, if base path for all metrics contains symlinks.

Crux of a problem is that _possibly_not_real_ "base_fs_path" is stripped from "realpath(self.fs_path)".
Problem can be easily solved by making sure that base_fs_path component is also processed by realpath() function.

Simple patch for storage.py to fix the issue is attached.

Revision history for this message
Mike Kazantsev (mk-fraggod) wrote :
Revision history for this message
Michael Leinartas (mleinartas) wrote :

Thanks for the patch, sorry for delay in applying

Changed in graphite:
assignee: nobody → Michael Leinartas (mleinartas)
importance: Undecided → High
status: New → Fix Committed
Changed in graphite:
milestone: none → 0.9.10
Changed in graphite:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.