NaN values being saved in Whisper datafiles

[Nicholas Leskiw]

NaN values are somehow getting stored in datafiles. They should be converted to None as they're being read into carbon-cache.py, or at minimum, glyph.py should be configured to convert them to None. Otherwise Cairo can't render the graph properly. rawData can still return the data properly.

[chrismd (chrismd)]

There was an explicit check for NaNs in the MetricPickleReceiver class but not in the MetricLineReceiver (or MetricDatagramReceiver) for that matter. I've fixed this by moving it to the base MetricReceiver class.

[Corry Haines (tabletcorry)]

Wow, that's service :)

Thanks!

[Corry Haines (tabletcorry)]

Will there be a fix committed to allow the render engine to filter these as well, or do I need to cleanse my datastores of the NaN values?

[chrismd (chrismd)]

Just committed that as well

[Nicholas Leskiw (nleskiw)]

Heh, I just posted that in the question. You need to cleanse the datastore by sending a 0 or None to the corresponding time of each nan, or completely erase the .wsp file and start over.

[Corry Haines (tabletcorry)]

Indeed, duplication.

I will do the "send 0" thing to all of the NaNs, should be pretty easy.

[Michael Leinartas (mleinartas)]

Released in 0.9.9