Improve timezone support

Bug #528228 reported by chrismd
32
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Graphite
Fix Released
Medium
Unassigned

Bug Description

We should allow the user to specify the timezone offset explicitly and also to support named timezones through an optional dependency on something like pytz.

chrismd (chrismd)
Changed in graphite:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
chrismd (chrismd) wrote :

I've added a dependency on pytz to allow support of Olson timezones and fixed the x-label formatting to be based off timezone-aware datetime objects instead of attempting to calculate the offset manually (which was quite error prone).

Changed in graphite:
status: Confirmed → Fix Committed
Revision history for this message
Nicholas Leskiw (nleskiw) wrote :

I installed a fresh copy of trunk, and all rendering fails with

ViewDoesNotExist: Could not import graphite.render.views. Error was: No module named pytz

It appears to be required (at least on Ubuntu 10.04)

Anyway, we can either add a fatal warning to check-dependencies.py or add a workaround if you don't want it to be required.
Or am I screwing something up?

Revision history for this message
Nicholas Leskiw (nleskiw) wrote :

After a sudo apt-get install python-tz rendering works. I'm guessing it's not optional right now.

Revision history for this message
chrismd (chrismd) wrote :

Correct, pytz is a new required dependency for Graphite. I am going to try and bundle it in the upcoming release so a separate installation of pytz isn't needed (but would override the bundled version if present).

chrismd (chrismd)
Changed in graphite:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.