whisper - create has wrong number of args

Bug #1064956 reported by Ed Saunders on 2012-10-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Graphite
New
Undecided
Unassigned

Bug Description

There have been changes made in carbon on branch 0.9.x to give support for fallocate - https://github.com/graphite-project/carbon/commit/4c6559276f3e753b93d22b79c7a0b75a50c06713#L2R118

However, in whisper the changes have been made to master, and don't exist on the 0.9.x branch

master - https://github.com/graphite-project/whisper/blob/master/whisper.py#L342
0.9.x - https://github.com/graphite-project/whisper/blob/0.9.x/whisper.py#L306

Consequently, when installing from scratch following your installation guides (http://graphite.wikidot.com/installation) it throws the following error when creating a new metric:

10/10/2012 11:44:35 :: [creates] new metric carbon.agents.tytan-a.cache.size matched schema carbon
10/10/2012 11:44:35 :: [creates] new metric carbon.agents.tytan-a.cache.size matched aggregation schema default
10/10/2012 11:44:35 :: [creates] creating database file /opt/graphite/storage/whisper/carbon/agents/tytan-a/cache/size.wsp (archive=[(60, 129600)] xff=None agg=None)
10/10/2012 11:44:35 :: [console] Unhandled Error
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 504, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib/python2.7/dist-packages/twisted/python/threadpool.py", line 207, in _worker
    result = context.call(ctx, function, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/twisted/python/context.py", line 118, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/lib/python2.7/dist-packages/twisted/python/context.py", line 81, in callWithContext
    return func(*args,**kw)
--- <exception caught here> ---
  File "/opt/graphite/lib/carbon/writer.py", line 158, in writeForever
    writeCachedDataPoints()
  File "/opt/graphite/lib/carbon/writer.py", line 128, in writeCachedDataPoints
    settings.WHISPER_FALLOCATE_CREATE)
exceptions.TypeError: create() takes at most 5 arguments (6 given)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers