Extra commas in composer_widgets.js breaks use of IE, again.

[Lance Reed]

Note, this is similar to, but a new bug than Bug #890743.
I will attach a patch file to fix.

I have a need to use Internet Explorer with the latest version of Graphite.

Whenever attempting to use the intro graphite page on 0.9.10 with IE 8 - I get the following error.

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; .NET4.0C; .NET4.0E; InfoPath.2)
Timestamp: Thu, 12 Jul 2012 04:56:30 UTC

Message: 'tagName' is null or not an object
Line: 11
Char: 27093
Code: 0
URI: https://lrvm22.XXXXXX.com/content/js/ext/ext-all.js

Tracked error to extra commas in composer_widgets.js.

cat composer_widgets.js_0_9_10.patch
--- composer_widgets.js.orig 2012-07-11 23:41:49.000000000 -0400
+++ composer_widgets.js 2012-07-12 00:33:23.000000000 -0400
@@ -1077,7 +1077,7 @@
     items: [
       menuInputItem("Time Format", "xFormat", "Enter the time format (see Python's datetime.strftime())", /^$/),
       menuInputItem("Timezone", "tz", "Enter the timezone to display (e.g. UTC or America/Chicago)"),
- menuInputItem("Point-width Consolidation Threshold", "minXStep", "Enter the closest number of pixels between points before consolidation"),
+ menuInputItem("Point-width Consolidation Threshold", "minXStep", "Enter the closest number of pixels between points before consolidation")
     ]
   });

@@ -1116,7 +1116,7 @@
         menu: {
           items: [
             menuCheckItem("Italics", "fontItalic"),
- menuCheckItem("Bold", "fontBold"),
+ menuCheckItem("Bold", "fontBold")
           ]
         }
       },
@@ -1156,7 +1156,7 @@
       menuCheckItem("Hide Axes", "hideAxes"),
       menuCheckItem("Hide Y-Axis", "hideYAxis"),
       menuCheckItem("Hide Grid", "hideGrid"),
- menuInputItem("Apply Template", "template", "Enter the name of a template defined in graphTemplates.conf", /^$/),
+ menuInputItem("Apply Template", "template", "Enter the name of a template defined in graphTemplates.conf", /^$/)
     ]
   });

[Lance Reed (reed-r-lance)]

Sorry,

This should have read:
Whenever attempting to use the intro graphite page on 0.9.10 with IE 8 - I get the error...
I cut and pasted from an old bug that was similar but did not change the version of graphite.
This IS a problem on the 0.9.10 version,. The patch file is attached.

Sorry for the confusion.

[Nicholas Leskiw (nleskiw)]

Pushed to master on github:
[master e098db9] Fix for Bug # 1023727, trailing comma on list items in Javascript file breaks IE compatibility.