Hinted Entry should have clear icon

Bug #1101771 reported by Julien Spautz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Granite
Fix Released
Low
Julien Spautz

Bug Description

The hinted entry should have a built-in symbolic clear button on the right end of the entry that only shows up when the entry is not empty.

Maybe the constructor should have a boolean argument to enable/disable the feature. There could also be a property for this.

The searchbar would also profit from this, since it's a subclass of the hinted entry.

Related branches

Revision history for this message
Cody Garver (codygarver) wrote :

lib/Widgets/Entries.vala already uses a symbolic clear icon, where else should there be one?

Changed in granite:
status: New → Incomplete
Revision history for this message
Julien Spautz (julien-spautz) wrote :

The HintedEntry does not have a built-in clear icon. Only the Searchbar class has one. Yet some people might want to use it in a normal HintedEntry, so maybe we could put the clear icon into the HintedEntry class. I just think it would be more convenient.

The constructor could look like this for compatibility:

 public HintedEntry (string hint_string, bool has_clear_icon = false);

Cody Garver (codygarver)
Changed in granite:
status: Incomplete → Confirmed
importance: Undecided → Low
Changed in granite:
assignee: nobody → Julien Spautz (julien-spautz)
status: Confirmed → In Progress
Cody Garver (codygarver)
Changed in granite:
milestone: none → luna-beta2
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.