Rewrite charm using template-python-pytests
Bug #1822329 reported by
Alvaro Uria
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Grafana Charm |
Fix Released
|
Wishlist
|
Unassigned |
Bug Description
Bug to track efforts to:
1) support unit and functional tests
2) rewrite the reactive script into modules (helpers)
Related branches
~aluria/charm-grafana:bug/1822329-tests
Rejected
for merging
into
~prometheus-charmers/charm-grafana:rewrite
- Xav Paice (community): Needs Fixing
- Stuart Bishop (community): Approve
- Chris Sanders (community): Needs Fixing
- BootStack Reviewers: Pending (mr tracking; do not claim) requested
- BootStack Reviewers: Pending requested
- BootStack Reviewers: Pending requested
- Alex Kavanagh: Pending requested
- Andrew McLeod: Pending requested
-
Diff: 1080 lines (+662/-159)16 files modified.gitignore (+4/-0)
actions/grafana_utils.py (+1/-1)
config.yaml (+28/-62)
dev/null (+0/-43)
lib/lib_grafana/db.py (+1/-1)
lib/lib_grafana/helpers.py (+4/-0)
reactive/grafana.py (+8/-10)
tests/functional/bundle.yaml (+189/-0)
tests/functional/conftest.py (+1/-2)
tests/functional/overlay.yaml.j2 (+11/-0)
tests/functional/requirements.txt (+1/-0)
tests/functional/test_deploy.py (+174/-24)
tests/unit/conftest.py (+52/-2)
tests/unit/test_lib.py (+121/-14)
tests/unit/test_libdb.py (+66/-0)
tox.ini (+1/-0)
~aluria/charm-grafana:bug/1822329-rewrite-01
- Peter Sabaini (community): Needs Fixing
- Alvaro Uria: Pending requested
-
Diff: 1496 lines (+646/-592)13 files modifiedMakefile (+2/-2)
dev/null (+0/-43)
lib/lib_grafana/__init__.py (+19/-0)
lib/lib_grafana/db.py (+179/-0)
lib/lib_grafana/helpers.py (+317/-0)
metadata.yaml (+0/-1)
reactive/grafana.py (+100/-512)
requirements.txt (+2/-0)
tests/unit/conftest.py (+8/-26)
tests/unit/example.cfg (+1/-0)
tests/unit/requirements.txt (+1/-0)
tests/unit/test_lib.py (+16/-7)
tox.ini (+1/-1)
~aluria/charm-grafana:add-pytests
Merged
into
~prometheus-charmers/charm-grafana:rewrite
at
revision 445abcffe757641bfadfc8856090a179ed13cf46
- Peter Sabaini (community): Needs Fixing
- Alvaro Uria: Pending requested
-
Diff: 1068 lines (+625/-139)18 files modified.gitignore (+22/-0)
Makefile (+55/-0)
actions/grafana_utils.py (+0/-1)
interfaces/.empty (+1/-0)
layer.yaml (+11/-1)
layers/.empty (+1/-0)
lib/lib_grafana.py (+43/-0)
metadata.yaml (+1/-1)
reactive/grafana.py (+94/-136)
reports/.empty (+0/-0)
requirements.txt (+1/-0)
tests/functional/conftest.py (+180/-0)
tests/functional/requirements.txt (+6/-0)
tests/functional/test_deploy.py (+50/-0)
tests/unit/conftest.py (+83/-0)
tests/unit/requirements.txt (+5/-0)
tests/unit/test_lib.py (+27/-0)
tox.ini (+45/-0)
Changed in grafana-charm: | |
status: | New → Confirmed |
importance: | Undecided → Wishlist |
Changed in grafana-charm: | |
assignee: | nobody → Alvaro Uria (aluria) |
status: | Confirmed → In Progress |
To post a comment you must log in.
Efforts also pushed at [1]. For now, lint or tests don't work, but the lib/lib_grafana/* package has been split in multiple files, and code in reactive/grafana.py has started to point to the defined classes and methods.
Work on fixing [1] branch will be delayed since this is not my primary assignment.
1. https:/ /code.launchpad .net/~aluria/ grafana- charm/+ git/grafana- charm-1/ +ref/bug/ 1822329- rewrite- 01