grafana charm has "port" option, but port 3000 is hardcoded in the template

Bug #1684523 reported by Nobuto Murata
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Grafana Charm
Fix Released
Medium
Joe Guo

Bug Description

[config.yaml]
  port:
    type: string
    default: "3000"
    description: |
        The port grafana will expose web services on.

[templates/grafana.ini.j2]
[server]
# Protocol (http or https)
;protocol = http

# The ip address to bind to, empty will bind to all interfaces
http_addr = 0.0.0.0

# The http port to use
http_port = 3000

Jacek Nykis (jacekn)
Changed in grafana-charm:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Tom Haddon (mthaddon) wrote :

The template now says:

http_port = {{ config['port'] }}

We should confirm this works as expected and can then close out the bug.

Somewhat related, there seems to be a mix of config styles here e.g. {{ config.root_url }}, {{ config['port'] }}. Consistency would be good.

Revision history for this message
Joe Guo (guoqiao) wrote :

Hi,
I've confirmed once I change port with:

juju config grafana port=3001

Then in unit, http_port will update in /etc/grafana/grafana.ini.

We can close this case.

Changed in charm-grafana:
assignee: nobody → Joe Guo (guoqiao)
Joe Guo (guoqiao)
Changed in charm-grafana:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.