non-linear curve fitting tool in grace returns rms relative error instead of rms percentage error

Bug #389238 reported by Alex Valavanis
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Grace
New
Undecided
Unassigned
grace (Debian)
Fix Released
Unknown
grace (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: grace

The non-linear curve fitting tool in grace outputs the wrong value next to "RMS per cent error:" It actually gives the RMS **relative** error, i.e. it is out by a factor of exactly 100.

The RMS per cent error should be given as:

e = 100 * (y'-y)^2/y^2

Patch attached

Revision history for this message
Alex Valavanis (valavanisalex) wrote :
Revision history for this message
Alex Valavanis (valavanisalex) wrote :
Changed in grace (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Brian Murray (brian-murray) wrote :

Thanks for taking the time to report this bug and including a patch for it too. This package is sync'ed with Debian, subsequently it'd be quite helpful if you were to submit this bug and your patch upstream to Debian. You can learn more about how to forward bugs to Debian at https://wiki.ubuntu.com/Debian/Bugs.

I realize you've also forward this directly to upstream which is great too! If we could get this into Debian or Debian to update from upstream that it would be one less diff that Ubuntu would have to carry. Thanks!

Revision history for this message
Alex Valavanis (valavanisalex) wrote :

I've made a report to Debian. Please could someone check that I haven't messed it up? :)

Changed in grace (Debian):
importance: Undecided → Unknown
status: New → Unknown
Changed in grace (Debian):
status: Unknown → New
Revision history for this message
Alex Valavanis (valavanisalex) wrote :

Merged upstream bugs

Changed in grace (Debian):
status: New → Unknown
Changed in grace (Debian):
status: Unknown → New
Changed in grace (Debian):
status: New → Fix Released
Revision history for this message
Alex Valavanis (valavanisalex) wrote :

grace (1:5.1.22-3) unstable; urgency=low

  * debian/control:
    - Adopt the package. (Closes: #459483)
    - Drop Suggests on grace-utils and Build-Depends option on g77, both no
      longer in the archive.
    - Bump Standards-Version to 3.8.3. No packaging changes necessary.
    - Remove Xs- prefix from Vcs-Svn.
  * debian/rules: Remove call to dh_desktop.
  * debian/grace.pre{inst,rm}: Set -e.
  * Add trivial manpage for grace-thumbnailer(1), links to grace(1).
  * Add debian/README.source.
  * New patches:
    - rmsdiff.patch: Display RMS percentage error as an actual percentage.
      Patch courtesy of Alex Valavanis. (Closes: #533761, 533762)
    - netbook_small_screen_2.diff: Improve display on small-resolution
      screens. Patch from feranick, Ubuntu LP #389238.
    - motiflockup.patch: Fix joint grace/X lockup when selecting new data
      set under certain circumstances. (Closes: #567323)
   * Updated patches:
    - grace_manpage_debian_warning.diff: Add whatis entry to grconvert(1).
 -- Alex Valavanis <email address hidden> Mon, 22 Feb 2010 14:05:58 +0000

Changed in grace (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.