[PATCH] Hibernate and Suspend actions, use dbus org.freedesktop.ConsoleKit + other improvements

Bug #973577 reported by Mantas Kriaučiūnas on 2012-04-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Gpoweroff
High
Philip Peitsch
Baltix
Undecided
Unassigned

Bug Description

I slightly improved Gpoweroff:
 - added Hibernate and Suspend actions,
 - changed dbus commands to modern universal org.freedesktop.ConsoleKit instead of outdated and GNOME-depending org.gnome.SessionManager,
 - fixed icon loading bugs (not all Linux distributions has gnome-session-* icons).

I'm attaching a patch with these improvements.
Philip, please add my improvements to official Gpoweroff sources and release new Ubuntu packages in PPA

I've tested patched Gpoweroff with Ubuntu+Kubuntu 11.04 and LinuxMint 12 (based on Ubuntu 11.10 with GNOME3 shell)

Related branches

Changed in gpoweroff:
status: New → In Progress
Mantas Kriaučiūnas (mantas) wrote :

Hi Philip,

I've created packaging recipe for Gpoweroff, see

https://code.launchpad.net/~gpoweroff/+recipe/gpoweroff

Unfortunately packaging code in lp:gpoweroff repository debian/rules file contains error and new gpoweroff packages doesn't build on Ubuntu 11.x and 12.04 :(

Here is last lines from build log:

dh_installmime -pgpoweroff
dh_installgsettings -pgpoweroff
dh_pysupport -pgpoweroff
make: dh_pysupport: Command not found
make: *** [binary-install-python/gpoweroff] Error 127
dpkg-buildpackage: error: /usr/bin/fakeroot debian/rules binary gave error exit status 2

For more info see full build log: https://launchpadlibrarian.net/101459805/buildlog_ubuntu-oneiric-i386.gpoweroff_12.04.2-0~79~oneiric1_FAILEDTOBUILD.txt.gz

Mantas Kriaučiūnas (mantas) wrote :

Hey, it seems python-support is deprecated since Ubuntu 11.10 (but still supported even in Ubuntu 12.04), see

http://www.rowinggolfer.org/tutorials/packaging/dh_python2_tutorial.html
http://wiki.debian.org/Python/TransitionToDHPython2

I think we could still use python-support for packaging for few months, maybe until Ubuntu 12.10, but in future we should use dh_python2, as recommends Ubuntu and Debian developers.

Philip Peitsch (philip-peitsch) wrote :

Hi Mantas,

Thanks very much for that. I've heard about recipes, but never got the opportunity to figure out how to use them. Fixed the build issue, so they are going through green now.

Philip Peitsch (philip-peitsch) wrote :

Good spotting on python-support being obsolete. I was basing my updates to the ones made in the quickly tool, but obviously they are behind the 8-ball on this. I've raised #979694 accordingly and will track those updates through there.

You help is very much appreciated :)

Philip, new gpoweroff packages currently are not installable in Ubuntu 11.04
and older because you've changes Depends to python-gobject-2 in debian/control
see http://bazaar.launchpad.net/~philip-peitsch/gpoweroff/trunk/revision/65#debian/control

please change Depends line in debian/control to

python-gobject-2 | python-gobject (<< 2.90.0)

Then Gpoweroff will work on all Ubuntu versions, even on 8.04 :)

On Thu, Apr 12, 2012 at 08:49:27AM -0000, Philip Peitsch wrote:
> Thanks very much for that. I've heard about recipes, but never got the
> opportunity to figure out how to use them. Fixed the build issue, so
> they are going through green now.
>
> --
> https://bugs.launchpad.net/bugs/973577
>
> Title:
> [PATCH] Hibernate and Suspend actions, use dbus
> org.freedesktop.ConsoleKit + other improvements

--
Labanaktis/Good luck,
Mantas Kriaučiūnas Jabber ID: <email address hidden> GPG ID: 43535BD5
Public organization "Open Source for Lithuania" - www.akl.lt
Geriausios biuro programos verslui ir namams - http://openoffice.lt
Prekyba naujais ir atnaujintais kompiuteriais su Linux OS - http://tinklas.eu
Naudok Baltix GNU/Linux sistemą savo kompiuteryje - http://baltix.lt

Changed in gpoweroff:
status: In Progress → Fix Committed
Changed in gpoweroff:
milestone: none → 12.04
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers