testing/swiftservice: data race
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Go OpenStack Exchange |
High
|
Dave Cheney | ||
| juju-core |
High
|
Dave Cheney |
Bug Description
Lots of data races when this package is used in anger.
2014/07/02 14:50:20 http: TLS handshake error from 127.0.0.1:58121: remote error: bad certificate
2014/07/02 14:50:20 http: TLS handshake error from 127.0.0.1:58124: remote error: bad certificate
==================
WARNING: DATA RACE
Read by goroutine 123:
runtime.
/
launchpad.
/
launchpad.
/
launchpad.
/
net/http.
/
net/http.
/
net/http.
/
Previous write by goroutine 54:
runtime.
/
launchpad.
/
launchpad.
/
launchpad.
/
net/http.
/
net/http.
/
net/http.
/
runtime.
/
math/
/
math/
/
math/
/
math/
/
crypto/
/
crypto/
/
crypto/
/
crypto/
/
github.
/
github.
/
github.
/
github.
/
github.
/
github.
/
github.
/
github.
/
github.
<
github.
/
github.
/
github.
/
runtime.call16()
/
reflect.
/
launchpad.
/
launchpad.
/
Goroutine 123 (running) created at:
net/http.
/
Goroutine 54 (running) created at:
net/http.
/
==================
==================
WARNING: DATA RACE
Read by goroutine 40:
runtime.
/
launchpad.
/
launchpad.
/
launchpad.
/
net/http.
/
net/http.
/
net/http.
/
Previous write by goroutine 94:
runtime.
/
launchpad.
/
launchpad.
/
launchpad.
/
net/http.
/
net/http.
/
net/http.
/
runtime.
/
crypto/
/
crypto/
/
crypto/
/
crypto/
/
crypto/
/
crypto/
/
crypto/
/
crypto/
/
net/http.
/
Goroutine 40 (running) created at:
net/http.
/
Goroutine 94 (running) created at:
net/http.
/
==================
==================
WARNING: DATA RACE
Read by goroutine 305:
runtime.
/
launchpad.
/
launchpad.
/
launchpad.
/
net/http.
/
net/http.
/
net/http.
/
Previous write by goroutine 233:
runtime.
/
launchpad.
/
launchpad.
/
launchpad.
/
net/http.
/
net/http.
/
net/http.
/
Goroutine 305 (running) created at:
net/http.
/
Goroutine 233 (running) created at:
net/http.
/
==================
OK: 77 passed, 5 skipped
PASS
Found 3 data race(s)
Related branches
- Juju Engineering: Pending requested 2014-07-02
-
Diff: 89 lines (+17/-0)1 file modifiedtestservices/swiftservice/service.go (+17/-0)
Changed in juju-core: | |
assignee: | nobody → Dave Cheney (dave-cheney) |
status: | New → In Progress |
Dave Cheney (dave-cheney) wrote : | #2 |
only on goose, I need to propose a fix to dependencies.tsv for
juju/juju, but that is blocked by the fact that juju doesn't appear to
be compatible with the head of goose.
On Wed, Jul 2, 2014 at 10:01 PM, John A Meinel <email address hidden> wrote:
> I think this is Fix Committed now, right?
>
>
> On Wed, Jul 2, 2014 at 9:33 AM, Dave Cheney <email address hidden>
> wrote:
>
>> Public bug reported:
>>
>> Lots of data races when this package is used in anger.
>>
>> 2014/07/02 14:50:20 http: TLS handshake error from 127.0.0.1:58121:
>> remote error: bad certificate
>> 2014/07/02 14:50:20 http: TLS handshake error from 127.0.0.1:58124:
>> remote error: bad certificate
>> ==================
>> WARNING: DATA RACE
>> Read by goroutine 123:
>> runtime.
>> /home/dfc/
>> launchpad.
>> /home/dfc/src/
>> launchpad.
>> launchpad.
>> /home/dfc/src/
>> launchpad.
>> launchpad.
>> /home/dfc/src/
>> launchpad.
>> net/http.
>> /home/dfc/
>> net/http.
>> /home/dfc/
>> net/http.
>> /home/dfc/
>>
>> Previous write by goroutine 54:
>> runtime.mapdelete()
>> /home/dfc/
>> launchpad.
>> /home/dfc/src/
>> launchpad.
>> launchpad.
>> /home/dfc/src/
>> launchpad.
>> launchpad.
>> /home/dfc/src/
>> launchpad.
>> net/http.
>> /home/dfc/
>> net/http.
>> /home/dfc/
>> net/http.
>> /home/dfc/
>> runtime.gosched0()
>> /home/dfc/
>> math/big.
>> /home/dfc/
>> math/big.
>> /home/dfc/
>> math/big.
>> /home/dfc/
>> math/big.
>> /home/dfc/
>> crypto/
>> /home/dfc/
>> crypto/
>> /home/dfc/
Dave Cheney (dave-cheney) wrote : | #3 |
https:/
Changed in goose: | |
status: | In Progress → Fix Committed |
assignee: | nobody → Dave Cheney (dave-cheney) |
Changed in juju-core: | |
importance: | Undecided → High |
milestone: | none → 1.21-alpha1 |
status: | In Progress → Fix Committed |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
Changed in goose: | |
status: | Fix Committed → Fix Released |
I think this is Fix Committed now, right?
On Wed, Jul 2, 2014 at 9:33 AM, Dave Cheney <email address hidden>
wrote:
> Public bug reported: mapaccess2_ faststr( ) go/src/ pkg/runtime/ hashmap_ fast.c: 122 +0x0 net/goose/ testservices/ swiftservice. (*Swift) .GetObject( ) net/goose/ testservices/ swiftservice/ service. go:83 +0x32a net/goose/ testservices/ swiftservice. (*Swift) .handleObjects( ) net/goose/ testservices/ swiftservice/ service_ http.go: 129 +0x215 net/goose/ testservices/ swiftservice. (*Swift) .ServeHTTP( ) net/goose/ testservices/ swiftservice/ service_ http.go: 200 +0x3fb (*ServeMux) .ServeHTTP( ) go/src/ pkg/net/ http/server. go:1511 +0x21c serverHandler. ServeHTTP( ) go/src/ pkg/net/ http/server. go:1673 +0x1fc (*conn) .serve( ) go/src/ pkg/net/ http/server. go:1174 +0xf9e go/src/ pkg/runtime/ hashmap. goc:948 +0x0 net/goose/ testservices/ swiftservice. (*Swift) .RemoveObject( ) net/goose/ testservices/ swiftservice/ service. go:181 +0x360 net/goose/ testservices/ swiftservice. (*Swift) .handleObjects( ) net/goose/ testservices/ swiftservice/ service_ http.go: 142 +0x400 net/goose/ testservices/ swiftservice. (*Swift) .ServeHTTP( ) net/goose/ testservices/ swiftservice/ service_ http.go: 200 +0x3fb (*ServeMux) .ServeHTTP( ) go/src/ pkg/net/ http/server. go:1511 +0x21c serverHandler. ServeHTTP( ) go/src/ pkg/net/ http/server. go:1673 +0x1fc (*conn) .serve( ) go/src/ pkg/net/ http/server. go:1174 +0xf9e go/src/ pkg/runtime/ proc.c: 1440 +0xbf nat.expNNWindow ed() go/src/ pkg/math/ big/nat. go:1359 +0xea8 nat.expNN( ) go/src/ pkg/math/ big/nat. go:1260 +0x4f1 nat.probablyPri me() go/src/ pkg/math/ big/nat. go:1445 +0x990 (*Int). ProbablyPrime( ) go/src/ pkg/math/ big/int. go:735 +0x7b rsa.(*PrivateKe y).Validate( ) go/src/ pkg/crypto/ rsa/rsa. go:91 +0x188 x509.ParsePKCS1 PrivateKey( ) go/src/ pkg/crypto/ x509/pkcs1. go:77 +0xa3c tls.parsePrivat eKey() go/src/ pkg/crypto/ tls/tls. go:259 +0x94 tls.X509KeyPair () go/src/ pkg/crypto/ tls/tls. go:213 +0x3f5 com/juju/ juju/environs/ config. verifyKeyPair( ) src/github. com/juju/ juju/environs/ config/ auth...
>
> Lots of data races when this package is used in anger.
>
> 2014/07/02 14:50:20 http: TLS handshake error from 127.0.0.1:58121:
> remote error: bad certificate
> 2014/07/02 14:50:20 http: TLS handshake error from 127.0.0.1:58124:
> remote error: bad certificate
> ==================
> WARNING: DATA RACE
> Read by goroutine 123:
> runtime.
> /home/dfc/
> launchpad.
> /home/dfc/src/
> launchpad.
> launchpad.
> /home/dfc/src/
> launchpad.
> launchpad.
> /home/dfc/src/
> launchpad.
> net/http.
> /home/dfc/
> net/http.
> /home/dfc/
> net/http.
> /home/dfc/
>
> Previous write by goroutine 54:
> runtime.mapdelete()
> /home/dfc/
> launchpad.
> /home/dfc/src/
> launchpad.
> launchpad.
> /home/dfc/src/
> launchpad.
> launchpad.
> /home/dfc/src/
> launchpad.
> net/http.
> /home/dfc/
> net/http.
> /home/dfc/
> net/http.
> /home/dfc/
> runtime.gosched0()
> /home/dfc/
> math/big.
> /home/dfc/
> math/big.
> /home/dfc/
> math/big.
> /home/dfc/
> math/big.
> /home/dfc/
> crypto/
> /home/dfc/
> crypto/
> /home/dfc/
> crypto/
> /home/dfc/
> crypto/
> /home/dfc/
> github.
> /home/dfc/