hard-coded German "magic number" strings do not translate

Bug #1025702 reported by Matthias Ronge on 2012-07-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Goobi.Production
Medium
Unassigned
1.8
Medium
Unassigned

Bug Description

In AktuelleSchritteForm.java, you find code like:

/* Schritteigenschaft seg = ... */
- seg.setTitel("Korrektur notwendig");
- seg.setTitel("Korrektur durchgefuehrt");

This should be made international, but functionality depends on these strings, notably in

- HistoryAnalyserJob.java, l. 282: if (prop.getTitel().equals("Korrektur notwendig")) {
- HistoryAnalyserJob2.java, l. 278: if (prop.getTitel().equals("Korrektur notwendig")) {
- HistoryJob.java, l. 279: if (prop.getTitel().equals("Korrektur notwendig") || [...]

There are aven more dependencies on the content of Schritteigenschaft's title field in ProductionDataImport.java, ll. 695-702:

----------
if (se.getTitel().contains("Anzahl der Images") || se.getTitel().contains("Anzahl der Seiten")
  || se.getTitel().contains("Seitenzahl")) {
 if (!se.getWert().equals(pd.getWERKSCANSEITEN())) {
  conflicts.add(new ImportConflicts(String.valueOf(s.getId()), "Seitenzahl", se.getWert(), String.valueOf(pd
    .getWERKSCANSEITEN())));
 }
 pages = true;
} else if (se.getTitel().contains("Scangerät")) {
----------

Translation should be possible here, too.

Matthias Ronge (matthias-ronge) wrote :

Changes must respect that those magic-number values are already in productive databases around the world. If internals are redesigned, this must be taken into account.

Data base content must not be changed. By mapping those "magic strings" to their data base representations, we should replace them with Enum types.

Changed in goobi-production:
importance: Undecided → Medium
status: New → Triaged
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers