search parameter doesn't survive multiple pages
Bug #984775 reported by
Henrik Lochmann
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Goobi.Presentation |
Fix Released
|
Low
|
Sebastian Meyer | ||
Bug Description
The frontend plugin "DLF: Search" does not take the search parameter across different pages. Thus, when a page that renders the search result list, also contains a "DLF: Search" plugin, its actual search field remains empty.
Related branches
lp:~sebastian-meyer/goobi-presentation/bug-984775
- Sebastian Meyer: Approve
-
Diff: 350 lines (+65/-34)7 files modifieddlf/lib/ISO-639/iso-639-1.xml (+21/-20)
dlf/lib/ISO-639/iso-639-2b.xml (+11/-8)
dlf/modules/newclient/locallang.xml (+2/-0)
dlf/modules/newclient/metadata.inc.php (+15/-1)
dlf/plugins/collection/class.tx_dlf_collection.php (+1/-1)
dlf/plugins/listview/class.tx_dlf_listview.php (+1/-1)
dlf/plugins/search/class.tx_dlf_search.php (+14/-3)
lp:goobi-presentation/1.1
- Sebastian Meyer: Approve
-
Diff: 6190 lines (+1826/-1558) (has conflicts)35 files modifieddlf/common/class.tx_dlf_document.php (+427/-367)
dlf/common/class.tx_dlf_helper.php (+189/-137)
dlf/common/class.tx_dlf_indexing.php (+138/-157)
dlf/common/class.tx_dlf_list.php (+51/-15)
dlf/common/class.tx_dlf_mods.php (+0/-12)
dlf/common/class.tx_dlf_module.php (+12/-14)
dlf/common/class.tx_dlf_plugin.php (+22/-10)
dlf/common/class.tx_dlf_solr.php (+14/-3)
dlf/ext_autoload.php (+30/-30)
dlf/ext_emconf.php (+33/-0)
dlf/ext_tables.php (+146/-145)
dlf/ext_tables.sql (+2/-1)
dlf/ext_tables_static+adt.sql (+1/-2)
dlf/hooks/class.tx_dlf_em.php (+166/-166)
dlf/hooks/class.tx_dlf_hacks.php (+21/-21)
dlf/hooks/class.tx_dlf_tceforms.php (+24/-24)
dlf/hooks/class.tx_dlf_tcemain.php (+50/-58)
dlf/locallang.xml (+0/-2)
dlf/modules/indexing/index.php (+2/-2)
dlf/modules/newclient/index.php (+1/-0)
dlf/modules/newclient/metadata.inc.php (+18/-3)
dlf/plugins/collection/class.tx_dlf_collection.php (+19/-15)
dlf/plugins/feeds/class.tx_dlf_feeds.php (+6/-6)
dlf/plugins/listview/class.tx_dlf_listview.php (+100/-93)
dlf/plugins/listview/locallang.xml (+2/-0)
dlf/plugins/metadata/class.tx_dlf_metadata.php (+91/-87)
dlf/plugins/navigation/class.tx_dlf_navigation.php (+2/-2)
dlf/plugins/oai/class.tx_dlf_oai.php (+124/-91)
dlf/plugins/pageview/class.tx_dlf_pageview.php (+33/-26)
dlf/plugins/search/class.tx_dlf_search.php (+39/-30)
dlf/plugins/search/locallang.xml (+2/-2)
dlf/plugins/statistics/class.tx_dlf_statistics.php (+5/-1)
dlf/plugins/toc/class.tx_dlf_toc.php (+23/-19)
dlf/plugins/toolbox/class.tx_dlf_toolbox.php (+8/-8)
dlf/tca.php (+25/-9)
| Changed in goobi-presentation: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
Revision history for this message
| Sebastian Meyer (sebastian-meyer) wrote | #1 |
| Changed in goobi-presentation: | |
| assignee: | nobody → Sebastian Meyer (sebastian-meyer) |
| Changed in goobi-presentation: | |
| milestone: | none → 1.1.1 |
| Changed in goobi-presentation: | |
| status: | Confirmed → Fix Released |
To post a comment you must log in.
The plugin saves the search parameters in the metadata section of the result list object "tx_dlf_list". Thus the search parameters are in fact available on other pages, but the "DLF: Search" plugin ignores them.
To fix the bug, there should be a check for an existing tx_dlf_list object in tx_dlf_search. If this object is available, the search parameters should be taken from its metadata section.