"DEFAULT" should be the only required file group.
Bug #747373 reported by
Sebastian Meyer
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Goobi.Presentation |
Fix Released
|
Wishlist
|
Sebastian Meyer | ||
| 1.0 |
Invalid
|
Undecided
|
Unassigned | ||
Bug Description
Currently all file groups can be configured via the extension's configuration except the two file groups "DEFAULT" and "THUMBS", which are regarded as required. There are several issues with that:
1) There is no warning if one of the file groups is missing.
2) If one is missing, the page view doesn't work (which is expected if "DEFAULT" is missing, but not if "THUMBS" is missing).
Solution: Only the file group "DEFAULT" should be regarded as required. The existence of the required and all configured file groups should be checked and an appropriate error message should be shown if one is missing. If there is no "THUMBS" file group, the page view plugin should display the pages anyway, but without the small overview map.
Related branches
lp:goobi-presentation/1.0
- Sebastian Meyer: Approve
-
Diff: 26 lines (+3/-2)2 files modifieddlf/ext_emconf.php (+1/-1)
dlf/plugins/pageview/viewer.js (+2/-1)
Revision history for this message
| Sebastian Meyer (sebastian-meyer) wrote | #1 |
To post a comment you must log in.
Instead of making "DEFAULT" the only required file group, I removed any requirements. Every file group has to be configured in the extension's settings.
There still is an issue with the OpenLayers viewer's overview map if you don't have a "THUMBS" file group, but that will be fixed when the whole viewer is re-factored, because it is a viewer bug.