Sends overlong summary which rietveld rejects
Bug #1015203 reported by
Martin Packman
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
goetveld |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
When using lbox to create a rietveld version of an already existing launchpad merge proposal, it failed at the submission step with:
2012/06/19 15:35:55 error: Failed to send patch set to codereview: Issue creation errors: {'subject': [u'Ensure this value has at most 100 characters (it has 204).']}
The first paragraph from the merge proposal, which lbox sets at the summary, was longer than the server was prepared to accept. (Also tried and failed to send several times, so lbox has no way to distinguish transient errors from this kind of bad request?)
Probably goetveld should just truncate the subject if it's given something overly large.
Related branches
lp:~gz/goetveld/chop_subject_1015203
Rejected
for merging
into
lp:~niemeyer/goetveld/trunk
- Gustavo Niemeyer: Pending requested
-
Diff: 69 lines (+34/-1)2 files modifiedrietveld.go (+13/-1)
rietveld_test.go (+21/-0)
To post a comment you must log in.
This was fixed at the time after a few helpful exchanges with Martin.