Random number generator is not seeded, leading to known paths

[Adam Collard]

gocheck uses temporary directories to run tests in, but these temporary directories are made with known, predictable names.

We can see here

http://bazaar.launchpad.net/~niemeyer/gocheck/trunk/view/head:/gocheck.go#L125

that newPath uses rand.Int() without first seeding the RNG. Meaning I'll always have tests run in /tmp/gocheck-5577006791947779410.

I don't think cryptographically secure random numbers are needed so something as simple as rand.Seed(time.Nanoseconds()) would probably do the job.

[Andreas Hasenack (ahasenack)]

Our CI is hitting this more frequently. We get directory name collisions in /tmp.

[Adam Collard (adam-collard)]

Filed in https://github.com/go-check/check/issues/45