many tests fail with gccgo
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
gocheck |
New
|
Undecided
|
Unassigned | ||
juju-core |
Fix Released
|
High
|
Dave Cheney |
Bug Description
$ go test -compiler gccgo launchpad.
...
OOPS: 76 passed, 48 FAILED
--- FAIL: Test (0.21 seconds)
FAIL
FAIL launchpad.
This mostly seems to be around type names in error messages being more qualified than gocheck expects or wants, for example:
FAIL: benchmark_
benchmark_
c.Assert(
... value string = "" +
... "PASS: gocheck_
... "PASS: gocheck_
... regex string = "" +
... "PASS: gocheck_
... "PASS: gocheck_
but debugging the tests of a testing library is stretching my go abilities, to put it mildly :)
Related branches
- Michael Hudson-Doyle: Approve
- John A Meinel: Approve
-
Diff: 48 lines (+3/-6)3 files modifiednova/local_test.go (+1/-2)
testservices/novaservice/service_http.go (+1/-1)
testservices/service.go (+1/-3)
Changed in juju-core: | |
assignee: | nobody → Dave Cheney (dave-cheney) |
Changed in juju-core: | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: gccgo |
Changed in juju-core: | |
milestone: | none → 1.18.0 |
tags: | added: ppc63el |
tags: |
added: ppc64el removed: ppc63el |
Changed in juju-core: | |
milestone: | 1.20.0 → next-stable |
Changed in juju-core: | |
status: | Triaged → Fix Released |
milestone: | next-stable → none |
The attached file seems to isolate the difference. It seems (*runtime. Func).Name is rather different with gccgo and without:
$ go run funcname.go net/gocheck. Suite net/gocheck. (*CheckerInfo) .Info net_gocheck. Suite
launchpad.
launchpad.
$ go run -compiler gccgo funcname.go
launchpad.
main.$thunk0