many tests fail with gccgo

Bug #1250253 reported by Michael Hudson-Doyle
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gocheck
New
Undecided
Unassigned
juju-core
Fix Released
High
Dave Cheney

Bug Description

$ go test -compiler gccgo launchpad.net/gocheck
...
OOPS: 76 passed, 48 FAILED
--- FAIL: Test (0.21 seconds)
FAIL
FAIL launchpad.net/gocheck 0.230s

This mostly seems to be around type names in error messages being more qualified than gocheck expects or wants, for example:

FAIL: benchmark_test.go:18: net_gocheck_test.TestBasicTestTiming.pN37_launchpad.net_gocheck_test.BenchmarkS

benchmark_test.go:26:
    c.Assert(output.value, Matches, expected)
... value string = "" +
... "PASS: gocheck_test.go:135: net_gocheck_test.Test1.pN40_launchpad.net_gocheck_test.FixtureHelper\t0.001s\n" +
... "PASS: gocheck_test.go:139: net_gocheck_test.Test2.pN40_launchpad.net_gocheck_test.FixtureHelper\t0.000s\n"
... regex string = "" +
... "PASS: gocheck_test\\.go:[0-9]+: FixtureHelper\\.Test1\t0\\.001s\n" +
... "PASS: gocheck_test\\.go:[0-9]+: FixtureHelper\\.Test2\t0\\.000s\n"

but debugging the tests of a testing library is stretching my go abilities, to put it mildly :)

Tags: gccgo ppc64el

Related branches

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

The attached file seems to isolate the difference. It seems (*runtime.Func).Name is rather different with gccgo and without:

$ go run funcname.go
launchpad.net/gocheck.Suite
launchpad.net/gocheck.(*CheckerInfo).Info
$ go run -compiler gccgo funcname.go
launchpad.net_gocheck.Suite
main.$thunk0

Changed in juju-core:
assignee: nobody → Dave Cheney (dave-cheney)
Curtis Hovey (sinzui)
Changed in juju-core:
status: New → Triaged
importance: Undecided → High
Curtis Hovey (sinzui)
tags: added: gccgo
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: none → 1.18.0
tags: added: ppc63el
tags: added: ppc64el
removed: ppc63el
Changed in juju-core:
milestone: 1.20.0 → next-stable
Curtis Hovey (sinzui)
Changed in juju-core:
status: Triaged → Fix Released
milestone: next-stable → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments