source of time is not consistent

Bug #604850 reported by toby schneider
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Goby
Fix Released
Low
toby schneider

Bug Description

we should remove use of <ctime> and double "Unix Time" in favor of boost date_time posix_time everywhere.

Related branches

toby schneider (tes)
Changed in goby:
importance: Undecided → Low
assignee: nobody → toby schneider (tes)
Revision history for this message
Chris Murphy (chrismurf) wrote :

I'm all for switching to an integer-based time ID (which I understand ptime is?), but is there a trivial way to convert ptime to unixtime? A quick perusal of the boost docs didn't yield an answer, and we rely on unixtime all over the place.

Revision history for this message
toby schneider (tes) wrote :

I've gone through and made changes to pretty much everything that involves time.

I've removed all uses of ctime and preferred the boost::date_time classes when possible. they are much more flexible to use when you get used to them. ctime is also annoying with its lack of sub-second precision.

i'm sure i'll find some bugs, so i'm keeping this as a branch for now. you can look at it if you want, but i'll test it and merge into trunk hopefully in a few days.

Revision history for this message
toby schneider (tes) wrote :

Fixed in revision 43. All time calls now should be made directly to boost::posix_time or through helper functions in util/time.h

Changed in goby:
status: New → Fix Committed
toby schneider (tes)
Changed in goby:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.