bucket.Put with object keys with spaces fails (fix included)

[Robert Carlsen]

The s3 request signing process signs a payload with an unescaped path. When amazon checks the signature, it does so on an escaped version of the path (containing the object key/name). All put requests with spaces in object keys fail with "The request signature we calculated does not match the signature you provided. Check your key and signing method.".

The fix I am using now is to escape "canonicalPath" var before passing it to the sign function. A diff of the fix below:

=== modified file 's3/s3.go'
--- s3/s3.go 2012-07-19 13:51:13 +0000
+++ s3/s3.go 2012-12-06 16:49:38 +0000
@@ -396,6 +396,7 @@
        if err != nil {
                return fmt.Errorf("bad S3 endpoint URL %q: %v", req.baseurl, err)
        }
+ canonicalPath = (&url.URL{Path: canonicalPath}).String()
        req.headers["Host"] = []string{u.Host}
        req.headers["Date"] = []string{time.Now().In(time.UTC).Format(time.RFC1123)}
        sign(s3.Auth, req.method, canonicalPath, req.params, req.headers)

[Paul Nakata (pmn)]

The suggested fix resolves the issue for me.

[Reed O'Brien (reedobrien)]

As of this writing I used the attached to make this work

[Christopher Proto (chroto24)]

The original patch no longer applies but the issue still exists.

This new patch should be applicable to trunk

[Adam Venturella (aventurella)]

This patch fixes it for me as well. I wasted a good few hours before I found this was the issue. This patch should be merged in, or an alternate solution provided.

[Akshay (a-projects)]

Lets merge this in please. It effects basic PUT functionality.

[Herman Schaaf (herman-5)]

The latest patch fixes the issue for me as well. It might be worth noting that this does not only affect files with spaces in the name, but also files with non-ASCII character names (台湾.csv, for example)