Breakpoint Toggling

[Aanjhan Ranganathan]

More of a usability improvement. It would be better to toggle breakpoints by clicking on the line number in the editor window or adding a menu entry in the right click menu of the source editor.

[Debjit Biswas (debjitbis08)]

I think the icon for the breakpoint should also be changed to something more familiar, like red blob or something. The present icon looks more like a delete button, new users may get confused.

[Onkar Shinde (onkarshinde)]

Debajit,

We use stock icons and menu items as defined by GTK as far as possible. In this case the icon is GTK_STOCK_NO ("gtk-no"). The icon for breakpoint is a 'red blob' if you use default icon theme for GNOME i.e. clearlooks. The reason we see it as a 'cross' (X) is because of the human (or humanity) icon theme used by Ubuntu.

[Debjit Biswas (debjitbis08)]

Hi,

I put together a quick patch for this.

1. I have used the "line-mark-activated" signal of GtkSourceView to toggle the breakpoint.
2. I have also modified the gui_editor_toggle_mark() function to accept a line number parameter.
3. Due to the above change I had to modify the bridge.c file where the above function is called.

--Debjit

[Debjit Biswas (debjitbis08)]

Sorry attached the wrong file...

[Onkar Shinde (onkarshinde)]

Debajit,

Thanks for the patch. I will take a look on weekend.

[Onkar Shinde (onkarshinde)]

I finally got around to reviewing the patch and committed the changes. I did following changes to the patch.
1. Introduced a new function for breakpoint toggling at a line, instead of modifying existing one.
2. Made sure that breakpoint toggling is only allowed in editor part and not assembly listing or tutorial window.