Desktop Icons NG gjs high CPU usage when moving/resizing any window

[openwebdesign]

Desktop Icons NG gjs high CPU usage when moving window - check enclosed video. When I disable Desktop Icons NG extensions CPU usage is fine.

System spec:
Intel® Core™ i7-2600 CPU @ 3.40GHz × 8
AMD® Radeon rx 560 series
Wayland
Ubuntu 22.04

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Daniel van Vugt (vanvugt)]

Confirmed on Intel graphics too.

[Sergio Costas (rastersoft-gmail)]

I can't reproduce this, neither in Debian SID, nor in an Ubuntu 22.04 in a virtual machine.

Are you using the desktop icons NG extension that is bundled with Ubuntu, or did you uninstall it and installed the last version from the git repository?

[Sergio Costas (rastersoft-gmail)]

Here is a freshly installed Ubuntu 22.04 inside a VirtualBox machine.

What other extensions do you have installed?

[Sergio Costas (rastersoft-gmail)]

I'll try to install ubuntu 22.04 in an old laptop with intel graphics and test it again... give me an hour.

[openwebdesign (info-openwebdesign)]

- Desktop Icons NG bundled with Ubuntu.
- I have disabled all extensions except NG icons and the problem persists.

[openwebdesign (info-openwebdesign)]

Installed extensions:
'<email address hidden>', '<email address hidden>', '<email address hidden>', 'just-perfection-desktop@just-perfection', '<email address hidden>', '<email address hidden>', '<email address hidden>'

[Sergio Costas (rastersoft-gmail)]

Thanks. I installed Ubuntu 22.04 in my laptop and I wasn't unable to reproduce this... until I found that, yes, when moving a window, the CPU usage in DING goes up. Not up to 100%, but up to 20%. Oddly enough, in my Debian PC it works fine and the CPU doesn't go up, but at least now I can reproduce it somehow.

[Sergio Costas (rastersoft-gmail)]

Ok, I have delimited the problem: in Ubuntu, when a window is moved, the desktop manager emits the size-changed signal (which should be emitted only when the desktop size has changed).

This is really odd.

I'll do some extra tests.

[Sergio Costas (rastersoft-gmail)]

https://gitlab.com/rastersoft/desktop-icons-ng/-/merge_requests/313 should fix this.

[Daniel van Vugt (vanvugt)]

Also assigned to gnome-shell/mutter since it sounds like the problem is originating there (comment #10).

[Daniel van Vugt (vanvugt)]

Dropped the gnome-shell/mutter tasks because it seems like most of the fault lies in DING.

https://gitlab.com/rastersoft/desktop-icons-ng/-/issues/219#note_885000330

[Daniel van Vugt (vanvugt)]

Actually we can optimize DING further...

[Daniel van Vugt (vanvugt)]

A more definitive fix is pending in https://gitlab.com/rastersoft/desktop-icons-ng/-/merge_requests/317

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-desktop-icons-ng - 43-1

---------------
gnome-shell-extension-desktop-icons-ng (43-1) unstable; urgency=medium

  * New upstream release

 -- Gunnar Hjalmarsson <email address hidden> Wed, 23 Mar 2022 15:03:28 +0100

[Daniel van Vugt (vanvugt)]

The final fix in comment #15 hasn't landed yet, but the changes in version 43-1 might be enough for this bug.

Not sure if we would reopen this bug or create a new one... I haven't yet measured the performance difference that the remaining fix would make.

[Gunnar Hjalmarsson (gunnarhj)]

Let's consider it partially fixed and reopen it.

[openwebdesign (info-openwebdesign)]

Thank you!

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-desktop-icons-ng - 43-2

---------------
gnome-shell-extension-desktop-icons-ng (43-2) unstable; urgency=medium

  * Cherry-pick translation updates & a fix for high CPU
    when moving or resizing a window (LP: #1965537)

 -- Jeremy Bicha <email address hidden> Tue, 12 Apr 2022 14:23:17 -0400

[donpdonp (don-park)]

I'm on Ubuntu 22.04 and this package is pegging my CPU at 100%

ii gnome-shell-extension-desktop-icons-ng 43-2ubuntu1 all desktop icon support for GNOME Shell

   PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
 157956 donp 20 0 3723044 263804 52196 R 109.3 3.3 0:54.62 gjs

 157956 ? Rl 1:14 gjs /<email address hidden>/ding.js -E -P /<email address hidden> -M 0 -D 0:0:1920:1080:1:27:0:74:0:0

if i kill -9, gnome launches another copy.

[Daniel van Vugt (vanvugt)]

If the gjs process is using high CPU then please attach gdb to it and run:

  call gjs_backtrace()

After a few attempts it should give a stack trace that will help us debug the problem.