openSUSE Build Failures (raised warnings)

[DimStar]

the openSUSE Build Service has a Policy based code checker enabled, which raises two warnings in the build to errors...:

E: gnome-dvb-daemon 64bit-portability-issue src/EPGScanner.c:433
E: gnome-dvb-daemon 64bit-portability-issue src/Scanner.c:334

The respective warnings from the build logs are
E: gnome-dvb-daemon 64bit-portability-issue src/EPGScanner.c:433
src/EPGScanner.c:433:9: warning: assignment makes pointer from integer without a cast
src/EPGScanner.c: In function 'dvb_epg_scanner_start':

E: gnome-dvb-daemon 64bit-portability-issue src/Scanner.c:334
src/Scanner.c:334:9: warning: assignment makes pointer from integer without a cast
src/Scanner.c: In function 'dvb_scanner_start_scan':

The code in question is:
static gpointer _dvb_epg_scanner_worker_gthread_func (gpointer self) {
        gpointer result;
        result = dvb_epg_scanner_worker (self);
        return result;
}

==> result is of type gpointer, whereas the return value of dvb_epg_scanner_worker is of type gboolean. Clearly not the same.
The same issue is in Scanner.c (without _epg_ in the function names obviously).

[Sebastian Pölsterl (sebp)]

The C code is generated by Vala, so we can't do anything about it. Nevertheless, the code should still work as expected, otherwise it would a bug in Vala.

[DimStar (dominique-launchpad-net)]

I tend to disagree to wave away errors like this.

the issue is rather simple: a pointer is no boolean.. and it's not even vala specifying this... it's actually in both reported cases (EPGScanner.vala and Scanner.vala) explicit code in gnome-dvb-daemon.

I took the liberty to create a patch solving the issues.

[Sebastian Pölsterl (sebp)]

Thanks a lot for the patch, I committed it.