Fails to build with vala 0.11.2

Bug #676263 reported by Andrew Starr-Bochicchio
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNOME DVB Daemon
Fix Released
High
Sebastian Pölsterl

Bug Description

Just wanted to give you a heads up that gnome-dvb-daemon is failing to compile with vala 0.11.2. Errors below:

src/Schedule.vala:223.83-223.102: error: Argument 2: Cannot convert from `DVB.EventElement.compare' to `GLib.CompareDataFunc<DVB.EventElement>'
            SequenceIter<EventElement> iter = this.events.insert_sorted (element, EventElement.compare);
                                                                                  ^^^^^^^^^^^^^^^^^^^^
src/Utils.vala:31.13-31.24: error: Equality operation: `null' and `GLib.EnumValue' are incompatible
        if (eval == null) {
            ^^^^^^^^^^^^
src/Utils.vala:43.13-43.24: error: Equality operation: `null' and `GLib.EnumValue' are incompatible
        if (eval == null) {
            ^^^^^^^^^^^^
src/io/RecordingWriter.vala:51.33-51.41: warning: string.size is deprecated. Use string.length
            stream.write (text, text.size (), null);
                                ^^^^^^^^^
src/io/RecordingWriter.vala:51.27-51.30: error: Argument 1: Cannot convert from `string?' to `uint8[]'
            stream.write (text, text.size (), null);
                          ^^^^
src/Settings.vala:69.53-69.73: warning: string.size is deprecated. Use string.length
                    stream.write (DEFAULT_SETTINGS, DEFAULT_SETTINGS.size(), null);
                                                    ^^^^^^^^^^^^^^^^^^^^^
src/Settings.vala:69.35-69.50: error: Argument 1: Cannot convert from `string' to `uint8[]'
                    stream.write (DEFAULT_SETTINGS, DEFAULT_SETTINGS.size(), null);
                                  ^^^^^^^^^^^^^^^^
src/Settings.vala:116.35-116.38: error: Argument 1: Cannot convert from `string?' to `uint8[]'
                stream.write_all (data, data_len, null, null);
                                  ^^^^
src/EPGScanner.vala:100.17-100.34: error: missing generic type arguments
                this.worker_thread.join ();
                ^^^^^^^^^^^^^^^^^^
src/EPGScanner.vala:144.38-144.50: error: cannot infer generic type argument for type parameter `GLib.Thread.create.T'
                this.worker_thread = Thread.create (this.worker, true);
                                     ^^^^^^^^^^^^^
src/Scanner.vala:158.38-158.50: error: cannot infer generic type argument for type parameter `GLib.Thread.create.T'
                this.worker_thread = Thread.create (this.worker, true);
                                     ^^^^^^^^^^^^^
src/Scanner.vala:202.17-202.34: error: missing generic type arguments
                this.worker_thread.join ();
                ^^^^^^^^^^^^^^^^^^
src/io/ChannelListWriter.vala:66.44-66.54: warning: string.size is deprecated. Use string.length
            this.stream.write_all (buffer, buffer.size(), null, null);
                                           ^^^^^^^^^^^
src/io/ChannelListWriter.vala:66.36-66.41: error: Argument 1: Cannot convert from `string?' to `uint8[]'
            this.stream.write_all (buffer, buffer.size(), null, null);
                                   ^^^^^^
src/Utils.vala:56.13-56.24: error: Equality operation: `null' and `GLib.EnumValue' are incompatible
        if (eval == null) {
            ^^^^^^^^^^^^
src/io/ChannelListWriter.vala:134.44-134.54: warning: string.size is deprecated. Use string.length
            this.stream.write_all (buffer, buffer.size(), null, null);
                                           ^^^^^^^^^^^
src/io/ChannelListWriter.vala:134.36-134.41: error: Argument 1: Cannot convert from `string?' to `uint8[]'
            this.stream.write_all (buffer, buffer.size(), null, null);
                                   ^^^^^^
src/io/ChannelListWriter.vala:142.44-142.54: warning: string.size is deprecated. Use string.length
            this.stream.write_all (buffer, buffer.size(), null, null);
                                           ^^^^^^^^^^^
src/io/ChannelListWriter.vala:142.36-142.41: error: Argument 1: Cannot convert from `string?' to `uint8[]'
            this.stream.write_all (buffer, buffer.size(), null, null);
                                   ^^^^^^
src/io/ChannelListWriter.vala:165.44-165.54: warning: string.size is deprecated. Use string.length
            this.stream.write_all (buffer, buffer.size(), null, null);
                                           ^^^^^^^^^^^
src/io/ChannelListWriter.vala:165.36-165.41: error: Argument 1: Cannot convert from `string?' to `uint8[]'
            this.stream.write_all (buffer, buffer.size(), null, null);
                                   ^^^^^^
src/io/ChannelListWriter.vala:88.44-88.54: warning: string.size is deprecated. Use string.length
            this.stream.write_all (buffer, buffer.size(), null, null);
                                           ^^^^^^^^^^^
src/io/ChannelListWriter.vala:88.36-88.41: error: Argument 1: Cannot convert from `string?' to `uint8[]'
            this.stream.write_all (buffer, buffer.size(), null, null);
                                   ^^^^^^
Compilation failed: 16 error(s), 8 warning(s)

Related branches

Revision history for this message
Sebastian Pölsterl (sebp) wrote :

I have a patch that fixes those issues, however valac prints lots of criticals while compiling. I'm waiting for feedback whether this is a critical issue which causes wrong generated code.

Changed in gnome-dvb-daemon:
status: New → Confirmed
assignee: nobody → Sebastian Pölsterl (sebp)
importance: Undecided → High
Changed in gnome-dvb-daemon:
status: Confirmed → Fix Committed
Changed in gnome-dvb-daemon:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.